Merge "Do not return synthetic launcher activity for completely headless apps" (ede2e771) · Commits · e / os / android_frameworks_base

services/core/java/com/android/server/pm/LauncherAppsService.java

+24 −30

Original line number	Diff line number	Diff line
		@@ -443,46 +443,40 @@ public class LauncherAppsService extends SystemService {
		if (isManagedProfileAdmin(user, appInfo.packageName)) {
		return false;
		}
		// If app does not have any components or any permissions, the app can legitimately
		// have no icon so we do not show the synthetic activity.
		return hasComponentsAndRequestsPermissions(appInfo.packageName);
		}

		private boolean hasComponentsAndRequestsPermissions(@NonNull String packageName) {
		final PackageManagerInternal pmInt =
		LocalServices.getService(PackageManagerInternal.class);
		final PackageParser.Package pkg = pmInt.getPackage(packageName);
		final PackageParser.Package pkg = pmInt.getPackage(appInfo.packageName);
		if (pkg == null) {
		// Should not happen, but we shouldn't be failing if it does
		return false;
		}
		if (ArrayUtils.isEmpty(pkg.requestedPermissions)) {
		return false;
		// If app does not have any default enabled launcher activity or any permissions,
		// the app can legitimately have no icon so we do not show the synthetic activity.
		return requestsPermissions(pkg) && hasDefaultEnableLauncherActivity(
		appInfo.packageName);
		}
		if (!hasApplicationDeclaredActivities(pkg)
		&& ArrayUtils.isEmpty(pkg.receivers)
		&& ArrayUtils.isEmpty(pkg.providers)
		&& ArrayUtils.isEmpty(pkg.services)) {
		return false;
		}
		return true;

		private boolean requestsPermissions(@NonNull PackageParser.Package pkg) {
		return !ArrayUtils.isEmpty(pkg.requestedPermissions);
		}

		private boolean hasApplicationDeclaredActivities(@NonNull PackageParser.Package pkg) {
		if (pkg.activities == null) {
		return false;
		private boolean hasDefaultEnableLauncherActivity(@NonNull String packageName) {
		final PackageManagerInternal pmInt =
		LocalServices.getService(PackageManagerInternal.class);
		final Intent matchIntent = new Intent(Intent.ACTION_MAIN);
		matchIntent.addCategory(Intent.CATEGORY_LAUNCHER);
		matchIntent.setPackage(packageName);
		final List<ResolveInfo> infoList = pmInt.queryIntentActivities(matchIntent,
		PackageManager.MATCH_DISABLED_COMPONENTS, Binder.getCallingUid(),
		getCallingUserId());
		final int size = infoList.size();
		for (int i = 0; i < size; i++) {
		if (infoList.get(i).activityInfo.enabled) {
		return true;
		}
		if (ArrayUtils.isEmpty(pkg.activities)) {
		return false;
		}
		// If it only contains synthetic AppDetailsActivity only, it means application does
		// not have actual activity declared in manifest.
		if (pkg.activities.size() == 1 && PackageManager.APP_DETAILS_ACTIVITY_CLASS_NAME.equals(
		pkg.activities.get(0).className)) {
		return false;
		}
		return true;
		}

		private boolean isManagedProfileAdmin(UserHandle user, String packageName) {
		final List<UserInfo> userInfoList = mUm.getProfiles(user.getIdentifier());