Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit edb27f14 authored by Raph Levien's avatar Raph Levien
Browse files

Revert "Revert "Use getRunAdvance to position cursor"" 

This reverts commit 5730c974.
parent 5730c974

core/java/android/text/Layout.java

+1 −0
Original line number Diff line number Diff line
@@ -1121,6 +1121,7 @@ public abstract class Layout { 
     * closest to the specified horizontal position.

     */

    public int getOffsetForHorizontal(int line, float horiz) {

        // TODO: use Paint.getOffsetForAdvance to avoid binary search

        int max = getLineEnd(line) - 1;

        int min = getLineStart(line);

        Directions dirs = getLineDirections(line);

core/java/android/text/TextLine.java

+4 −6
Original line number Diff line number Diff line
@@ -739,16 +739,14 @@ class TextLine { 


        float ret = 0;



        int contextLen = contextEnd - contextStart;

        if (needWidth || (c != null && (wp.bgColor != 0 || wp.underlineColor != 0 || runIsRtl))) {

            if (mCharsValid) {

                ret = wp.getTextRunAdvances(mChars, start, runLen,

                        contextStart, contextLen, runIsRtl, null, 0);

                ret = wp.getRunAdvance(mChars, start, contextEnd, contextStart, contextEnd,

                        runIsRtl, end);

            } else {

                int delta = mStart;

                ret = wp.getTextRunAdvances(mText, delta + start,

                        delta + end, delta + contextStart, delta + contextEnd,

                        runIsRtl, null, 0);

                ret = wp.getRunAdvance(mText, delta + start, delta + contextEnd,

                        delta + contextStart, delta + contextEnd, runIsRtl, delta + end);

            }

        }