Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed9a847e authored by Nicolo' Mazzucato's avatar Nicolo' Mazzucato
Browse files

Group notification related instant event under a track group 

This makes notification instant event appear under an "notification" top level group in perfetto when opening a process specific workflow (see aosp/3435719)

Bug: 337016334
Test: perfetto trace
Flag: NONE logging change
Change-Id: I21b8095faf1373530db3af333864abd0a838e24d
parent 4c004e1f

packages/SystemUI/src/com/android/systemui/statusbar/notification/logging/NotificationLogger.java

+3 −3
Original line number Diff line number Diff line
@@ -20,7 +20,6 @@ import android.os.Handler; 
import android.os.RemoteException;

import android.os.ServiceManager;

import android.os.SystemClock;

import android.os.Trace;

import android.service.notification.NotificationListenerService;

import android.util.ArrayMap;

import android.util.ArraySet;
@@ -29,6 +28,7 @@ import android.util.Log; 
import androidx.annotation.NonNull;

import androidx.annotation.Nullable;



import com.android.app.tracing.coroutines.TrackTracer;

import com.android.internal.annotations.GuardedBy;

import com.android.internal.annotations.VisibleForTesting;

import com.android.internal.statusbar.IStatusBarService;
@@ -152,8 +152,8 @@ public class NotificationLogger implements StateListener, CoreStartable, 


            mExpansionStateLogger.onVisibilityChanged(

                    mTmpCurrentlyVisibleNotifications, mTmpCurrentlyVisibleNotifications);

            Trace.traceCounter(Trace.TRACE_TAG_APP, "Notifications [Active]", N);

            Trace.traceCounter(Trace.TRACE_TAG_APP, "Notifications [Visible]",

            TrackTracer.instantForGroup("Notifications", "Active", N);

            TrackTracer.instantForGroup("Notifications", "Visible",

                    mCurrentlyVisibleNotifications.size());



            recycleAllVisibilityObjects(mTmpNoLongerVisibleNotifications);

packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/ui/view/NotificationStatsLoggerImpl.kt

+3 −3
Original line number Diff line number Diff line
@@ -16,9 +16,9 @@ 


package com.android.systemui.statusbar.notification.stack.ui.view



import android.os.Trace

import android.service.notification.NotificationListenerService

import androidx.annotation.VisibleForTesting

import com.android.app.tracing.coroutines.TrackTracer

import com.android.internal.statusbar.IStatusBarService

import com.android.internal.statusbar.NotificationVisibility

import com.android.systemui.dagger.SysUISingleton
@@ -183,8 +183,8 @@ constructor( 


            maybeLogVisibilityChanges(newlyVisible, noLongerVisible, activeNotifCount)

            updateExpansionStates(newlyVisible, noLongerVisible)

            Trace.traceCounter(Trace.TRACE_TAG_APP, "Notifications [Active]", activeNotifCount)

            Trace.traceCounter(Trace.TRACE_TAG_APP, "Notifications [Visible]", newVisibilities.size)

            TrackTracer.instantForGroup("Notifications", "Active", activeNotifCount)

            TrackTracer.instantForGroup("Notifications", "Visible", newVisibilities.size)



            lastLoggedVisibilities.clear()

            lastLoggedVisibilities.putAll(newVisibilities)