Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed5d295c authored by Josh's avatar Josh
Browse files

Refactored PhoneStatusBarView to remove Dependency.get()

Dependency.get() in the view constructor leads to faulty test behaviour
as unrelated dagger dependencies are getting instantiated.

This is also a legacy way of handling dependency injections in general.

The Logic related to statusBarWindowControllerStore has been moved from
inside PhoneStatusBarView to PhoneStatusBarViewController with the store
injected into the constructor by dagger, removing the need for
Dependency.get and also allowing Test environments to inject their
version of statusBarWindowControllerStore

Flag: EXEMPT Refactor
Test: PhoneStatusBarViewControllerTest, PhoneStatusBarViewTest
Fix: 442337871
Change-Id: I18d995f89b59560fc2429843de55cdc853977c73
parent ccfd479b
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment