Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ecfbddbc authored by Jason Monk's avatar Jason Monk
Browse files

Fix QS Detail header touch target 

Move around some spacings and paddings to make sure the whole area
counts as a touch for the header.

Test: manual
Change-Id: I3d7515767cc3624efb195481886dc03c69cc39c9
Fixes: 38250837
parent 8d902a9e

packages/SystemUI/res/layout/qs_detail.xml

+0 −4
Original line number Diff line number Diff line
@@ -26,10 +26,6 @@ 
    android:paddingBottom="8dp"

    android:visibility="invisible">



    <com.android.systemui.ResizingSpace

        android:layout_width="match_parent"

        android:layout_height="@dimen/qs_detail_margin_top" />



    <include

        android:id="@+id/qs_detail_header"

        layout="@layout/qs_detail_header"

packages/SystemUI/res/layout/qs_detail_header.xml

+36 −24
Original line number Diff line number Diff line
@@ -20,11 +20,21 @@ 
    android:layout_height="wrap_content"

    android:paddingLeft="@dimen/qs_detail_header_padding"

    android:paddingTop="@dimen/qs_detail_header_padding"

    android:paddingBottom="@dimen/qs_detail_header_bottom_padding"

    android:paddingBottom="@dimen/qs_detail_items_padding_top"

    android:paddingEnd="@dimen/qs_panel_padding"

    android:background="@drawable/btn_borderless_rect"

    android:orientation="vertical"

    android:gravity="center">



    <com.android.systemui.ResizingSpace

        android:layout_width="match_parent"

        android:layout_height="@dimen/qs_detail_margin_top" />



    <LinearLayout

        android:layout_width="match_parent"

        android:layout_height="wrap_content"

        android:orientation="horizontal">



        <TextView

            android:id="@android:id/title"

            android:paddingStart="@dimen/qs_detail_header_text_padding"
@@ -50,4 +60,6 @@ 
            android:clickable="false"

            android:textAppearance="@style/TextAppearance.QS.DetailHeader" />



    </LinearLayout>



</com.android.keyguard.AlphaOptimizedLinearLayout>

packages/SystemUI/res/layout/qs_detail_items.xml

+0 −1
Original line number Diff line number Diff line
@@ -20,7 +20,6 @@ 
    xmlns:sysui="http://schemas.android.com/apk/res-auto"

    android:layout_width="match_parent"

    android:layout_height="match_parent"

    android:paddingTop="@dimen/qs_detail_items_padding_top"

    android:paddingStart="@dimen/qs_detail_padding_start"

    android:paddingEnd="16dp">

packages/SystemUI/res/layout/zen_mode_panel.xml

+0 −1
Original line number Diff line number Diff line
@@ -36,7 +36,6 @@ 
            android:layout_height="wrap_content"

            android:layout_marginStart="16dp"

            android:layout_marginEnd="16dp"

            android:layout_marginTop="8dp"

            android:layout_marginBottom="8dp" />



        <RelativeLayout

packages/SystemUI/res/values/dimens.xml

+0 −1
Original line number Diff line number Diff line
@@ -249,7 +249,6 @@ 
    <dimen name="qs_panel_padding_bottom">0dp</dimen>

    <dimen name="qs_detail_header_height">56dp</dimen>

    <dimen name="qs_detail_header_padding">0dp</dimen>

    <dimen name="qs_detail_header_bottom_padding">0dp</dimen>

    <dimen name="qs_detail_image_width">56dp</dimen>

    <dimen name="qs_detail_image_height">56dp</dimen>

    <dimen name="qs_detail_image_padding">16dp</dimen>