Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ecbb47cf authored by Tony Huang's avatar Tony Huang
Browse files

Update divider value when config changed 

Divider size and insets value might be changed when config changed,
we should update them too otherwise divider would keep same area
on SplitLayout but actually view area become small or large.

Bug: 256117210
Test: manual
Test: pass existing tests
Change-Id: I6532f41c58848797f14ae17cb26f1ae734c53573
parent 18ef8a8d

libs/WindowManager/Shell/src/com/android/wm/shell/common/split/SplitLayout.java

+13 −11
Original line number Diff line number Diff line
@@ -85,9 +85,9 @@ public final class SplitLayout implements DisplayInsetsController.OnInsetsChange 
    private static final int FLING_ENTER_DURATION = 350;

    private static final int FLING_EXIT_DURATION = 350;



    private final int mDividerWindowWidth;

    private final int mDividerInsets;

    private final int mDividerSize;

    private int mDividerWindowWidth;

    private int mDividerInsets;

    private int mDividerSize;



    private final Rect mTempRect = new Rect();

    private final Rect mRootBounds = new Rect();
@@ -130,6 +130,7 @@ public final class SplitLayout implements DisplayInsetsController.OnInsetsChange 
        mContext = context.createConfigurationContext(configuration);

        mOrientation = configuration.orientation;

        mRotation = configuration.windowConfiguration.getRotation();

        mDensity = configuration.densityDpi;

        mSplitLayoutHandler = splitLayoutHandler;

        mDisplayImeController = displayImeController;

        mSplitWindowManager = new SplitWindowManager(windowName, mContext, configuration,
@@ -138,24 +139,22 @@ public final class SplitLayout implements DisplayInsetsController.OnInsetsChange 
        mImePositionProcessor = new ImePositionProcessor(mContext.getDisplayId());

        mSurfaceEffectPolicy = new ResizingEffectPolicy(parallaxType);



        final Resources resources = context.getResources();

        mDividerSize = resources.getDimensionPixelSize(R.dimen.split_divider_bar_width);

        mDividerInsets = getDividerInsets(resources, context.getDisplay());

        mDividerWindowWidth = mDividerSize + 2 * mDividerInsets;

        updateDividerConfig(mContext);



        mRootBounds.set(configuration.windowConfiguration.getBounds());

        mDividerSnapAlgorithm = getSnapAlgorithm(mContext, mRootBounds, null);

        resetDividerPosition();



        mDimNonImeSide = resources.getBoolean(R.bool.config_dimNonImeAttachedSide);

        mDimNonImeSide = mContext.getResources().getBoolean(R.bool.config_dimNonImeAttachedSide);



        updateInvisibleRect();

    }



    private int getDividerInsets(Resources resources, Display display) {

    private void updateDividerConfig(Context context) {

        final Resources resources = context.getResources();

        final Display display = context.getDisplay();

        final int dividerInset = resources.getDimensionPixelSize(

                com.android.internal.R.dimen.docked_stack_divider_insets);



        int radius = 0;

        RoundedCorner corner = display.getRoundedCorner(RoundedCorner.POSITION_TOP_LEFT);

        radius = corner != null ? Math.max(radius, corner.getRadius()) : radius;
@@ -166,7 +165,9 @@ public final class SplitLayout implements DisplayInsetsController.OnInsetsChange 
        corner = display.getRoundedCorner(RoundedCorner.POSITION_BOTTOM_LEFT);

        radius = corner != null ? Math.max(radius, corner.getRadius()) : radius;



        return Math.max(dividerInset, radius);

        mDividerInsets = Math.max(dividerInset, radius);

        mDividerSize = resources.getDimensionPixelSize(R.dimen.split_divider_bar_width);

        mDividerWindowWidth = mDividerSize + 2 * mDividerInsets;

    }



    /** Gets bounds of the primary split with screen based coordinate. */
@@ -308,6 +309,7 @@ public final class SplitLayout implements DisplayInsetsController.OnInsetsChange 
        mRotation = rotation;

        mDensity = density;

        mDividerSnapAlgorithm = getSnapAlgorithm(mContext, mRootBounds, null);

        updateDividerConfig(mContext);

        initDividerPosition(mTempRect);

        updateInvisibleRect();