Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ec5cada5 authored by hyung4.kim's avatar hyung4.kim
Browse files

Fixed Handler Leak on WrapperInit 



Handler is not closed by IOException

Detected by static analysis

Test: Manual

Signed-off-by: default avatarhyung4.kim <hyung4.kim@samsung.com>
Change-Id: I702387572dafbd6cbd3ed2c2ecb71760b2725fe8
parent 3acec4d1

core/java/com/android/internal/os/WrapperInit.java

+3 −2
Original line number Diff line number Diff line
@@ -69,15 +69,16 @@ public class WrapperInit { 
        // Tell the Zygote what our actual PID is (since it only knows about the

        // wrapper that it directly forked).

        if (fdNum != 0) {

            try {

            FileDescriptor fd = new FileDescriptor();

            try {

                fd.setInt$(fdNum);

                DataOutputStream os = new DataOutputStream(new FileOutputStream(fd));

                os.writeInt(Process.myPid());

                os.close();

                IoUtils.closeQuietly(fd);

            } catch (IOException ex) {

                Slog.d(TAG, "Could not write pid of wrapped process to Zygote pipe.", ex);

            } finally {

                IoUtils.closeQuietly(fd);

            }

        }