Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ebf1f791 authored by Angela Wang's avatar Angela Wang
Browse files

Clear exisiting listeners in SliderPreference.onBindViewHolder() 

If the view is reused, the old listeners will still remain on the
instance and cause wrong behavior. Should clear the old listeners before
adding the new one.

Flag: EXEMPT update library
Test: visual test
Bug: 349675952
Bug: 385089184
Change-Id: Iaee4996132422bb0e0d41984cd7982df4bde67f6
parent 7d92eb07

packages/SettingsLib/SliderPreference/src/com/android/settingslib/widget/SliderPreference.java

+2 −0
Original line number Diff line number Diff line
@@ -268,7 +268,9 @@ public class SliderPreference extends Preference { 
        mSlider.setValueFrom(mMin);

        mSlider.setValueTo(mMax);

        mSlider.setValue(mSliderValue);

        mSlider.clearOnSliderTouchListeners();

        mSlider.addOnSliderTouchListener(mTouchListener);

        mSlider.clearOnChangeListeners();

        mSlider.addOnChangeListener(mChangeListener);

        mSlider.setEnabled(isEnabled());