Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ebc3a17b authored by Hongyu Long's avatar Hongyu Long
Browse files

a11y: Ignore the unittest causing crash 

We have two Magnification Delegate dialogs. For the old one, we don't
set dismissal for it; for the new one, we set dismissal for it to
disable shortcut. The new one is behind a flag, which we enable it by
default recently. Thus, the crashing unittest is creating the new Mag
dialog which will crash during `tearDown()`. We already have one CL
ag/35510953 to update the test fixture for fixing the dismissal crash.

This CL will ignore the crashing unittest which is tempopry fix to let
it not affect others in main branch.

Bug: b/443556122
Flag: com.android.hardware.input.enable_magnify_magnification_key_gesture_dialog
Test: atest KeyGestureDialogStartableTest
Change-Id: Iec4ecb84d9895debaea8d338f3afca0376624e9e
parent 7914382b

packages/SystemUI/multivalentTests/src/com/android/systemui/accessibility/keygesture/ui/KeyGestureDialogStartableTest.kt

+8 −1
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ 
package com.android.systemui.accessibility.keygesture.ui



import android.hardware.input.KeyGestureEvent

import android.platform.test.annotations.DisableFlags

import android.platform.test.annotations.EnableFlags

import android.view.Display.DEFAULT_DISPLAY

import androidx.test.annotation.UiThreadTest
@@ -80,8 +81,10 @@ class KeyGestureDialogStartableTest : SysuiTestCase() { 
    fun tearDown() {

        // If we show the dialog, we must dismiss the dialog at the end of the test on the main

        // thread.

        if (::underTest.isInitialized) {

            underTest.currentDialog?.dismiss()

        }

    }



    @Test

    fun start_doesNotShowDialogByDefault() =
@@ -93,6 +96,8 @@ class KeyGestureDialogStartableTest : SysuiTestCase() { 
        }



    @Test

    @Ignore("b/425722546 - we have one in review CL ag/35510953 for fixing the crash")

    @DisableFlags(Flags.FLAG_ENABLE_MAGNIFY_MAGNIFICATION_KEY_GESTURE_DIALOG)

    fun start_onMagnificationInfoFlowCollected_showDialog() =

        testScope.runTest {

            underTest.start()
@@ -114,6 +119,8 @@ class KeyGestureDialogStartableTest : SysuiTestCase() { 
        }



    @Test

    @Ignore("b/425722546 - we have one in review CL ag/35510953 for fixing the crash")

    @DisableFlags(Flags.FLAG_ENABLE_MAGNIFY_MAGNIFICATION_KEY_GESTURE_DIALOG)

    fun start_onMagnificationInfoFlowCollected_dialogShowing_ignoreAdditionalFlows() =

        testScope.runTest {

            underTest.start()