Commit eb0208bc authored May 02, 2025 by Yurii Zubrytskyi

Update ServiceRecord's appInfo on overlay changes

ApplicationInfo in ServiceRecord is rarely used, so the code
used to not update them for runtime overlay changes and there
were no known issues with that. Turns out, there's a specific
case when it does matter:

An app has a service that's auto-restarting, and an activity
that starts the service. If any overlay changes happen after the
service start, we never update the service record. Then, if the
activity crashes, we restart just the service using it's (stale)
application info, and it doesn't get the latest overlay paths.

This change applies the new ApplicationInfo when
OverlayManagerService sends an update also to all running
services in the process

Bug: 414686685
Test: manual with the CL attached to the bug
Flag: EXEMPT bugfix
Change-Id: I3475adb33fa30a7df672fc0c03d1a1031f99f047

parent ca9279ee

services/core/java/com/android/server/am/ProcessList.java

+8 −0

Original line number	Diff line number	Diff line
		@@ -5245,6 +5245,14 @@ public final class ProcessList {
		PlatformCompatCache.getInstance()
		.onApplicationInfoChanged(ai);
		}
		// Service fields rarely matter, but if we're restarting an app's
		// service when it has no running activities, we're using these cached
		// ones, and they have to be up to date.
		for (int j = app.mServices.numberOfRunningServices() - 1; j >= 0; j--) {
		final ServiceRecord sr = app.mServices.getRunningServiceAt(j);
		sr.appInfo = ai;
		sr.serviceInfo.applicationInfo = ai;
		}
		app.getThread().scheduleApplicationInfoChanged(ai);
		targetProcesses.add(app.getWindowProcessController());
		}