Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eafbce55 authored by Shimeng (Simon) Wang's avatar Shimeng (Simon) Wang
Browse files

Ignore overflow:hidden in overview mode. 

The feature was enabled to prevent flash sites from flickering due to
viewport height change when the site is scrolled.

Now fixed viewport height is in honeycomb, this flickering shall be
a non-issue.  So to support better scrolling of overflow:hidden sites
and better consistency, overflow:hidden in overview mode is ignored
as well.

Tested on flash site http://home.disney.go.com/mwc.index to make sure
no flickering happens.  More testing shall be done once good flash
player is there.

issue: 3330038
Change-Id: Ia3f61ce49cfb970d26976d4e876c337d210a9df2
parent d5208cf4

core/java/android/webkit/WebView.java

+0 −8
Original line number Diff line number Diff line
@@ -2618,10 +2618,6 @@ public class WebView extends AbsoluteLayout 
    private int computeRealHorizontalScrollRange() {

        if (mDrawHistory) {

            return mHistoryWidth;

        } else if (mHorizontalScrollBarMode == SCROLLBAR_ALWAYSOFF

                && !mZoomManager.canZoomOut()) {

            // only honor the scrollbar mode when it is at minimum zoom level

            return computeHorizontalScrollExtent();

        } else {

            // to avoid rounding error caused unnecessary scrollbar, use floor

            return (int) Math.floor(mContentWidth * mZoomManager.getScale());
@@ -2652,10 +2648,6 @@ public class WebView extends AbsoluteLayout 
    private int computeRealVerticalScrollRange() {

        if (mDrawHistory) {

            return mHistoryHeight;

        } else if (mVerticalScrollBarMode == SCROLLBAR_ALWAYSOFF

                && !mZoomManager.canZoomOut()) {

            // only honor the scrollbar mode when it is at minimum zoom level

            return computeVerticalScrollExtent();

        } else {

            // to avoid rounding error caused unnecessary scrollbar, use floor

            return (int) Math.floor(mContentHeight * mZoomManager.getScale());