Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eab42d9f authored by Neil Fuller's avatar Neil Fuller
Browse files

Document a section of code 

Document a section of code that prevents an NTP-related CTS test working
if the device is not connected to Wifi. The reason the code exists took
a little bit of research, so here it is.

Bug: 213393821
Test: Comment-only change
Change-Id: I0b5d9f298ef36e861f780a29fdf74f0226fa1567
parent 9b420e66

core/java/android/util/NtpTrustedTime.java

+10 −0
Original line number Diff line number Diff line
@@ -193,6 +193,16 @@ public class NtpTrustedTime implements TrustedTime { 
            }

            final Network network = connectivityManager.getActiveNetwork();

            final NetworkInfo ni = connectivityManager.getNetworkInfo(network);



            // This connectivity check is to avoid performing a DNS lookup for the time server on a

            // unconnected network. There are races to obtain time in Android when connectivity

            // changes, which means that forceRefresh() can be called by various components before

            // the network is actually available. This led in the past to DNS lookup failures being

            // cached (~2 seconds) thereby preventing the device successfully making an NTP request

            // when connectivity had actually been established.

            // A side effect of check is that tests that run a fake NTP server on the device itself

            // will only be able to use it if the active network is connected, even though loopback

            // addresses are actually reachable.

            if (ni == null || !ni.isConnected()) {

                if (LOGD) Log.d(TAG, "forceRefresh: no connectivity");

                return false;