Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9b05cc8 authored by Roger Olsson's avatar Roger Olsson Committed by Steve Kondik
Browse files

TabWidget orientation 

TabWidget orientation specified in tab_content.xml instead of TabWidget.java.
Generally, the orientation of the TabWidget should be set in xml-files
and not in TabWidget.java. A sub class of TabActivity may call setContentView()
using a custom layout where the TabWidget orientation is vertical.
This is the case in the UI Enablers Bottom Tab feature, for landscape
display orientation.

Change-Id: Ia677441a0af96a8d2ab47ef3298eb440c34924f6
parent 7190b344

core/java/android/widget/TabWidget.java

+0 −1
Original line number Diff line number Diff line
@@ -109,7 +109,6 @@ public class TabWidget extends LinearLayout implements OnFocusChangeListener { 
    }



    private void initTabWidget() {

        setOrientation(LinearLayout.HORIZONTAL);

        mGroupFlags |= FLAG_USE_CHILD_DRAWING_ORDER;



        final Context context = mContext;

core/res/res/layout/tab_content.xml

+3 −2
Original line number Diff line number Diff line
@@ -22,7 +22,8 @@ 
	android:layout_width="match_parent" android:layout_height="match_parent">

	<LinearLayout android:orientation="vertical"

    	android:layout_width="match_parent" android:layout_height="match_parent">

        <TabWidget android:id="@android:id/tabs" android:layout_width="match_parent"

    <TabWidget android:id="@android:id/tabs"

        android:orientation="horizontal" android:layout_width="match_parent"

        android:layout_height="wrap_content" android:layout_weight="0" />

        <FrameLayout android:id="@android:id/tabcontent"

        	android:layout_width="match_parent" android:layout_height="0dip"