Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9953b17 authored by Robert Carr's avatar Robert Carr
Browse files

Force pending transactions to flush before screenshot. 

Following 14e54ba747 (ag/1043009) we need to push an empty
synchronous transaction if we want to ensure all previous
transactions have occured before taking a screenshot. In
light of Bug 7552304 it seems wise to do this before screenshoting
applications.

Bug: 27098060
Bug: 7552304
Change-Id: I6d7dfbe634a288c55449d2f1d6fbbfc13bab08ad
parent 2486cb2c

core/java/android/view/SurfaceControl.java

+6 −2
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ public class SurfaceControl { 
            boolean allLayers, boolean useIdentityTransform);



    private static native void nativeOpenTransaction();

    private static native void nativeCloseTransaction();

    private static native void nativeCloseTransaction(boolean sync);

    private static native void nativeSetAnimationTransaction();



    private static native void nativeSetLayer(long nativeObject, int zorder);
@@ -372,7 +372,11 @@ public class SurfaceControl { 


    /** end a transaction */

    public static void closeTransaction() {

        nativeCloseTransaction();

        nativeCloseTransaction(false);

    }



    public static void closeTransactionSync() {

        nativeCloseTransaction(true);

    }



    public void deferTransactionUntil(IBinder handle, long frame) {

core/jni/android_view_SurfaceControl.cpp

+4 −3
Original line number Diff line number Diff line
@@ -223,8 +223,9 @@ static void nativeOpenTransaction(JNIEnv* env, jclass clazz) { 
    SurfaceComposerClient::openGlobalTransaction();

}



static void nativeCloseTransaction(JNIEnv* env, jclass clazz) {

    SurfaceComposerClient::closeGlobalTransaction();



static void nativeCloseTransaction(JNIEnv* env, jclass clazz, jboolean sync) {

    SurfaceComposerClient::closeGlobalTransaction(sync);

}



static void nativeSetAnimationTransaction(JNIEnv* env, jclass clazz) {
@@ -649,7 +650,7 @@ static const JNINativeMethod sSurfaceControlMethods[] = { 
            (void*)nativeScreenshot },

    {"nativeOpenTransaction", "()V",

            (void*)nativeOpenTransaction },

    {"nativeCloseTransaction", "()V",

    {"nativeCloseTransaction", "(Z)V",

            (void*)nativeCloseTransaction },

    {"nativeSetAnimationTransaction", "()V",

            (void*)nativeSetAnimationTransaction },

services/core/java/com/android/server/wm/WindowManagerService.java

+5 −0
Original line number Diff line number Diff line
@@ -6381,6 +6381,11 @@ public class WindowManagerService extends IWindowManager.Stub 
            if (DEBUG_SCREENSHOT && inRotation) Slog.v(TAG_WM,

                    "Taking screenshot while rotating");



            // We force pending transactions to flush before taking

            // the screenshot by pushing an empty synchronous transaction.

            SurfaceControl.openTransaction();

            SurfaceControl.closeTransactionSync();



            bm = SurfaceControl.screenshot(crop, width, height, minLayer, maxLayer,

                    inRotation, rot);

            if (bm == null) {