Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e97f9b67 authored by Tracy Zhou's avatar Tracy Zhou
Browse files

Revert "Pass down whether iterating through tasks in overview is..." 

Revert submission 20956764-alt_tab_forward

Reason for revert: Actually we dont need these changes after all. SHIFT doesn't matter in the initial tab to overview. The subsequent tabs are handled by RecentsView and we already have a check on shift

Reverted changes: /q/submissionid:20956764-alt_tab_forward

Change-Id: Iaf62d47b239a680c84df2f226fd36484a36b84dd
parent 1160db2a

core/java/com/android/internal/statusbar/IStatusBar.aidl

+1 −1
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ oneway interface IStatusBar 
            boolean showImeSwitcher);

    void setWindowState(int display, int window, int state);



    void showRecentApps(boolean triggeredFromAltTab, boolean forward);

    void showRecentApps(boolean triggeredFromAltTab);

    void hideRecentApps(boolean triggeredFromAltTab, boolean triggeredFromHomeKey);

    void toggleRecentApps();

    void toggleSplitScreen();

packages/SystemUI/shared/src/com/android/systemui/shared/recents/IOverviewProxy.aidl

+1 −1
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ oneway interface IOverviewProxy { 
    /**

     * Sent when overview is to be shown.

     */

    void onOverviewShown(boolean triggeredFromAltTab, boolean forward) = 7;

    void onOverviewShown(boolean triggeredFromAltTab) = 7;



    /**

     * Sent when overview is to be hidden.

packages/SystemUI/src/com/android/systemui/recents/OverviewProxyRecentsImpl.java

+2 −2
Original line number Diff line number Diff line
@@ -59,11 +59,11 @@ public class OverviewProxyRecentsImpl implements RecentsImplementation { 
    }



    @Override

    public void showRecentApps(boolean triggeredFromAltTab, boolean forward) {

    public void showRecentApps(boolean triggeredFromAltTab) {

        IOverviewProxy overviewProxy = mOverviewProxyService.getProxy();

        if (overviewProxy != null) {

            try {

                overviewProxy.onOverviewShown(triggeredFromAltTab, forward);

                overviewProxy.onOverviewShown(triggeredFromAltTab);

            } catch (RemoteException e) {

                Log.e(TAG, "Failed to send overview show event to launcher.", e);

            }

packages/SystemUI/src/com/android/systemui/recents/Recents.java

+2 −2
Original line number Diff line number Diff line
@@ -65,14 +65,14 @@ public class Recents implements CoreStartable, CommandQueue.Callbacks { 
    }



    @Override

    public void showRecentApps(boolean triggeredFromAltTab, boolean forward) {

    public void showRecentApps(boolean triggeredFromAltTab) {

        // Ensure the device has been provisioned before allowing the user to interact with

        // recents

        if (!isUserSetup()) {

            return;

        }



        mImpl.showRecentApps(triggeredFromAltTab, forward);

        mImpl.showRecentApps(triggeredFromAltTab);

    }



    @Override

packages/SystemUI/src/com/android/systemui/recents/RecentsImplementation.java

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ public interface RecentsImplementation { 


    default void preloadRecentApps() {}

    default void cancelPreloadRecentApps() {}

    default void showRecentApps(boolean triggeredFromAltTab, boolean forward) {}

    default void showRecentApps(boolean triggeredFromAltTab) {}

    default void hideRecentApps(boolean triggeredFromAltTab, boolean triggeredFromHomeKey) {}

    default void toggleRecentApps() {}