Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e89adafd authored by Ioana Alexandru's avatar Ioana Alexandru
Browse files

[Notif redesign] Expander: use paddings, not margins 

This improves the touch area when the button is centered and when the
notification is expanded - it ensures that the touch target is always at
least the size of the button + 16dp in all directions (so at least
60x52, which is larger than the recommended 48x48 for a11y).

Bug: 378660052
Test: used the hierarchy viewer to check the bounds of the Button
Flag: android.app.notifications_redesign_templates
Change-Id: I7eebe058588a398b56362fd8b66028a76fb9a267
parent 4da4efc9

core/res/res/layout/notification_2025_expand_button.xml

+1 −0
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ 
    android:layout_height="wrap_content"

    android:layout_gravity="top|end"

    android:contentDescription="@string/expand_button_content_description_collapsed"

    android:padding="@dimen/notification_2025_margin"

    >



    <LinearLayout

core/res/res/layout/notification_2025_template_collapsed_base.xml

+0 −1
Original line number Diff line number Diff line
@@ -168,7 +168,6 @@ 
                android:layout_width="wrap_content"

                android:layout_height="wrap_content"

                android:layout_gravity="top|end"

                android:layout_margin="@dimen/notification_2025_margin"

                />



        </FrameLayout>

core/res/res/layout/notification_2025_template_collapsed_call.xml

+0 −1
Original line number Diff line number Diff line
@@ -70,7 +70,6 @@ 
                android:layout_width="wrap_content"

                android:layout_height="wrap_content"

                android:layout_gravity="top|end"

                android:layout_margin="@dimen/notification_2025_margin"

                />



        </FrameLayout>

core/res/res/layout/notification_2025_template_collapsed_media.xml

+0 −1
Original line number Diff line number Diff line
@@ -189,7 +189,6 @@ 
                android:layout_width="wrap_content"

                android:layout_height="wrap_content"

                android:layout_gravity="top|end"

                android:layout_margin="@dimen/notification_2025_margin"

                />



        </FrameLayout>

core/res/res/layout/notification_2025_template_collapsed_messaging.xml

+0 −1
Original line number Diff line number Diff line
@@ -193,7 +193,6 @@ 
                        android:layout_width="wrap_content"

                        android:layout_height="wrap_content"

                        android:layout_gravity="top|end"

                        android:layout_margin="@dimen/notification_2025_margin"

                        />



                </FrameLayout>