Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8836cd0 authored by Veeti Paananen's avatar Veeti Paananen Committed by Joey Rizzoli
Browse files

Tweak Privacy Guard dialog layout 

Make the "remember choice" check text clickable. Adjust margins to match
Material spec. Remove crazy table layout.

Change-Id: Ibeabdf693dc9273ba80f21fab399868fecac9054
parent 79509bcd

core/res/res/layout/permission_confirmation_dialog.xml

+10 −31
Original line number Diff line number Diff line
@@ -25,43 +25,22 @@ 
    android:id="@+id/parentPanel"

    android:layout_width="match_parent"

    android:layout_height="wrap_content"

    android:layout_marginLeft="8dip"

    android:layout_marginRight="8dip"

    android:orientation="vertical">



    <TextView android:id="@+id/permission_text"

        style="?android:attr/textAppearanceMedium"

        android:layout_width="match_parent"

        android:layout_height="wrap_content"

        android:paddingLeft="20dip"

        android:paddingRight="20dip"

        android:paddingTop="16dip"

        android:paddingBottom="16dip" />

        android:paddingLeft="24dp"

        android:paddingRight="24dp"

        android:paddingTop="16dp"

        android:paddingBottom="16dp" />



    <TableLayout android:id="@+id/permission_remember_layout"

        android:shrinkColumns="1"

        android:layout_width="wrap_content"

        android:layout_height="wrap_content"

        android:gravity="center_vertical"

        android:paddingLeft="16dip"

        android:paddingRight="16dip">



        <TableRow

            android:layout_width="wrap_content"

            android:layout_height="wrap_content" >

            <RelativeLayout android:layout_width="wrap_content"

                android:layout_height="wrap_content"

                android:paddingLeft="8dip" >

    <CheckBox android:id="@+id/permission_remember_choice_checkbox"

                android:layout_width="wrap_content"

        style="?android:attr/textAppearanceSmall"

        android:text="@string/permission_remember_choice"

        android:layout_marginStart="18dp"

        android:layout_width="match_parent"

        android:layout_height="wrap_content" />

            </RelativeLayout>

            <TextView android:id="@+id/permission_remember_choice_text"

                android:layout_width="wrap_content"

                android:layout_height="wrap_content"

                android:text="@string/permission_remember_choice" />

        </TableRow>



    </TableLayout>



</LinearLayout>

core/res/res/values/cm_symbols.xml

+0 −2
Original line number Diff line number Diff line
@@ -38,9 +38,7 @@ 
    <java-symbol type="string" name="privacy_guard_dialog_title" />

    <java-symbol type="string" name="privacy_guard_dialog_summary" />

    <java-symbol type="id" name="permission_text" />

    <java-symbol type="id" name="permission_remember_layout" />

    <java-symbol type="id" name="permission_remember_choice_checkbox" />

    <java-symbol type="id" name="permission_remember_choice_text" />

    <java-symbol type="string" name="allow" />

    <java-symbol type="string" name="deny" />

    <java-symbol type="layout" name="permission_confirmation_dialog" />