Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e76ba1de authored by Yeabkal Wubshit's avatar Yeabkal Wubshit
Browse files

Minor optimization: avoid unneeded computation in DisplayStateController 

The doze override display state always take effect if present, so
avoid doing any state calculation before checking/applying doze
override display state.

Flag: EXEMPT
Test: presubmit
Change-Id: Idd6efc6d6d57f5fdd8c68ae5166a474ba95a221d
parent 5325f2b2

services/core/java/com/android/server/display/DisplayPowerController.java

+3 −2
Original line number Diff line number Diff line
@@ -1540,12 +1540,13 @@ final class DisplayPowerController implements AutomaticBrightnessController.Call 
                performScreenOffTransition = true;

                break;

            case DisplayPowerRequest.POLICY_DOZE:

                if (mPowerRequest.dozeScreenState != Display.STATE_UNKNOWN) {

                if (mDozeStateOverride != Display.STATE_UNKNOWN) {

                    state = mDozeStateOverride;

                } else if (mPowerRequest.dozeScreenState != Display.STATE_UNKNOWN) {

                    state = mPowerRequest.dozeScreenState;

                } else {

                    state = Display.STATE_DOZE;

                }

                state = mDozeStateOverride == Display.STATE_UNKNOWN ? state : mDozeStateOverride;

                if (!mAllowAutoBrightnessWhileDozingConfig) {

                    brightnessState = mPowerRequest.dozeScreenBrightness;

                    mBrightnessReasonTemp.setReason(BrightnessReason.REASON_DOZE);

services/core/java/com/android/server/display/state/DisplayStateController.java

+3 −2
Original line number Diff line number Diff line
@@ -61,12 +61,13 @@ public class DisplayStateController { 
                mPerformScreenOffTransition = true;

                break;

            case DisplayManagerInternal.DisplayPowerRequest.POLICY_DOZE:

                if (displayPowerRequest.dozeScreenState != Display.STATE_UNKNOWN) {

                if (mDozeStateOverride != Display.STATE_UNKNOWN) {

                    state = mDozeStateOverride;

                } else if (displayPowerRequest.dozeScreenState != Display.STATE_UNKNOWN) {

                    state = displayPowerRequest.dozeScreenState;

                } else {

                    state = Display.STATE_DOZE;

                }

                state = mDozeStateOverride == Display.STATE_UNKNOWN ? state : mDozeStateOverride;

                break;

            case DisplayManagerInternal.DisplayPowerRequest.POLICY_DIM:

            case DisplayManagerInternal.DisplayPowerRequest.POLICY_BRIGHT: