Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e7178a23 authored by Kenny Root's avatar Kenny Root
Browse files

Convert LockSettingsService tests to JUnit4 

In preparation for adding more tests to LockSettingsService, convert the
existing JUnit3 tests to JUnit4 like the tests in the
recoverablekeystore subdirectory.

Test: atest FrameworksServicesTests:CachedSyntheticPasswordTests \
            FrameworksServicesTests:LockSettingsServiceTests \
            FrameworksServicesTests:LockSettingsShellCommandTest \
            FrameworksServicesTests:LockSettingsStorageTests \
            FrameworksServicesTests:LockscreenFrpTest \
            FrameworksServicesTests:PasswordSlotManagerTests \
            FrameworksServicesTests:SP800DeriveTests
Test: atest FrameworksServicesTests:SyntheticPasswordTests \
            FrameworksServicesTests:WeaverBasedSyntheticPasswordTests
Bug: 145144304
Change-Id: Iaf280718d4c28966b60c76dda90a4674a24f26c6
parent e197dad5

services/tests/servicestests/src/com/android/server/locksettings/BaseLockSettingsServiceTests.java

+24 −19
Original line number Diff line number Diff line
@@ -16,10 +16,12 @@ 


package com.android.server.locksettings;



import static org.mockito.Matchers.any;

import static org.mockito.Matchers.anyBoolean;

import static org.mockito.Matchers.anyInt;

import static org.mockito.Matchers.eq;

import static org.junit.Assert.assertFalse;

import static org.junit.Assert.assertTrue;

import static org.mockito.ArgumentMatchers.any;

import static org.mockito.ArgumentMatchers.anyBoolean;

import static org.mockito.ArgumentMatchers.anyInt;

import static org.mockito.ArgumentMatchers.eq;

import static org.mockito.Mockito.doAnswer;

import static org.mockito.Mockito.mock;

import static org.mockito.Mockito.when;
@@ -47,7 +49,9 @@ import android.os.UserManagerInternal; 
import android.os.storage.IStorageManager;

import android.os.storage.StorageManager;

import android.security.KeyStore;

import android.test.AndroidTestCase;



import androidx.test.InstrumentationRegistry;

import androidx.test.runner.AndroidJUnit4;



import com.android.internal.widget.ILockSettings;

import com.android.internal.widget.LockPatternUtils;
@@ -57,6 +61,9 @@ import com.android.server.LocalServices; 
import com.android.server.locksettings.recoverablekeystore.RecoverableKeyStoreManager;

import com.android.server.wm.WindowManagerInternal;



import org.junit.After;

import org.junit.Before;

import org.junit.runner.RunWith;

import org.mockito.invocation.InvocationOnMock;

import org.mockito.stubbing.Answer;
@@ -64,8 +71,8 @@ import java.io.File; 
import java.util.ArrayList;

import java.util.Arrays;





public abstract class BaseLockSettingsServiceTests extends AndroidTestCase {

@RunWith(AndroidJUnit4.class)

public abstract class BaseLockSettingsServiceTests {

    protected static final int PRIMARY_USER_ID = 0;

    protected static final int MANAGED_PROFILE_USER_ID = 12;

    protected static final int TURNED_OFF_PROFILE_USER_ID = 17;
@@ -107,10 +114,8 @@ public abstract class BaseLockSettingsServiceTests extends AndroidTestCase { 
    protected boolean mHasSecureLockScreen;

    FakeSettings mSettings;



    @Override

    protected void setUp() throws Exception {

        super.setUp();



    @Before

    public void setUp_baseServices() throws Exception {

        mGateKeeperService = new FakeGateKeeperService();

        mNotificationManager = mock(NotificationManager.class);

        mUserManager = mock(UserManager.class);
@@ -135,11 +140,12 @@ public abstract class BaseLockSettingsServiceTests extends AndroidTestCase { 
        LocalServices.addService(DevicePolicyManagerInternal.class, mDevicePolicyManagerInternal);

        LocalServices.addService(WindowManagerInternal.class, mMockWindowManager);



        mContext = new MockLockSettingsContext(getContext(), mUserManager, mNotificationManager,

                mDevicePolicyManager, mock(StorageManager.class), mock(TrustManager.class),

                mock(KeyguardManager.class), mFingerprintManager, mFaceManager, mPackageManager);

        mContext = new MockLockSettingsContext(InstrumentationRegistry.getContext(), mUserManager,

                mNotificationManager, mDevicePolicyManager, mock(StorageManager.class),

                mock(TrustManager.class), mock(KeyguardManager.class), mFingerprintManager,

                mFaceManager, mPackageManager);

        mStorage = new LockSettingsStorageTestable(mContext,

                new File(getContext().getFilesDir(), "locksettings"));

                new File(InstrumentationRegistry.getContext().getFilesDir(), "locksettings"));

        File storageDir = mStorage.mStorageDir;

        if (storageDir.exists()) {

            FileUtils.deleteContents(storageDir);
@@ -283,11 +289,10 @@ public abstract class BaseLockSettingsServiceTests extends AndroidTestCase { 
        }).when(mFaceManager).remove(any(), eq(userId), any());

    }



    @Override

    protected void tearDown() throws Exception {

        super.tearDown();

    @After

    public void tearDown_baseServices() throws Exception {

        mStorage.closeDatabase();

        File db = getContext().getDatabasePath("locksettings.db");

        File db = InstrumentationRegistry.getContext().getDatabasePath("locksettings.db");

        assertTrue(!db.exists() || db.delete());



        File storageDir = mStorage.mStorageDir;

services/tests/servicestests/src/com/android/server/locksettings/CachedSyntheticPasswordTests.java

+12 −3
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ package com.android.server.locksettings; 


import static com.android.server.testutils.TestUtils.assertExpectException;



import static org.junit.Assert.assertEquals;

import static org.mockito.Mockito.anyInt;

import static org.mockito.Mockito.atLeastOnce;

import static org.mockito.Mockito.verify;
@@ -26,10 +27,14 @@ import android.os.RemoteException; 
import android.platform.test.annotations.Presubmit;



import androidx.test.filters.SmallTest;

import androidx.test.runner.AndroidJUnit4;



import com.android.internal.widget.LockscreenCredential;

import com.android.internal.widget.VerifyCredentialResponse;



import org.junit.Before;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.mockito.ArgumentCaptor;



import java.util.ArrayList;
@@ -42,11 +47,11 @@ import java.util.ArrayList; 
 */

@SmallTest

@Presubmit

@RunWith(AndroidJUnit4.class)

public class CachedSyntheticPasswordTests extends SyntheticPasswordTests {



    @Override

    protected void setUp() throws Exception {

        super.setUp();

    @Before

    public void enableSpCache() throws Exception {

        enableSpCaching(true);

    }
@@ -55,6 +60,7 @@ public class CachedSyntheticPasswordTests extends SyntheticPasswordTests { 
                .canUserHaveUntrustedCredentialReset(anyInt())).thenReturn(enable);

    }



    @Test

    public void testSyntheticPasswordClearCredentialUntrusted() throws RemoteException {

        final LockscreenCredential password = newPassword("password");

        final LockscreenCredential newPassword = newPassword("newpassword");
@@ -74,6 +80,7 @@ public class CachedSyntheticPasswordTests extends SyntheticPasswordTests { 
        assertNotEquals(sid, mGateKeeperService.getSecureUserId(PRIMARY_USER_ID));

    }



    @Test

    public void testSyntheticPasswordChangeCredentialUntrusted() throws RemoteException {

        final LockscreenCredential password = newPassword("password");

        final LockscreenCredential newPassword = newPassword("newpassword");
@@ -91,6 +98,7 @@ public class CachedSyntheticPasswordTests extends SyntheticPasswordTests { 
                newPassword, 0, PRIMARY_USER_ID).getResponseCode());

    }



    @Test

    public void testUntrustedCredentialChangeMaintainsAuthSecret() throws RemoteException {

        final LockscreenCredential password = newPassword("password");

        final LockscreenCredential newPassword = newPassword("newpassword");
@@ -111,6 +119,7 @@ public class CachedSyntheticPasswordTests extends SyntheticPasswordTests { 
        assertEquals(1, secret.getAllValues().stream().distinct().count());

    }



    @Test

    public void testUntrustedCredentialChangeBlockedIfSpNotCached() throws RemoteException {

        final LockscreenCredential password = newPassword("password");

        final LockscreenCredential newPassword = newPassword("newpassword");

services/tests/servicestests/src/com/android/server/locksettings/LockSettingsServiceTests.java

+35 −14
Original line number Diff line number Diff line
@@ -21,6 +21,12 @@ import static com.android.internal.widget.LockPatternUtils.CREDENTIAL_TYPE_PASSW 
import static com.android.internal.widget.LockPatternUtils.CREDENTIAL_TYPE_PATTERN;

import static com.android.internal.widget.LockPatternUtils.CREDENTIAL_TYPE_PIN;



import static org.junit.Assert.assertEquals;

import static org.junit.Assert.assertFalse;

import static org.junit.Assert.assertNotNull;

import static org.junit.Assert.assertNull;

import static org.junit.Assert.assertTrue;

import static org.junit.Assert.fail;

import static org.mockito.ArgumentMatchers.any;

import static org.mockito.ArgumentMatchers.anyInt;

import static org.mockito.ArgumentMatchers.eq;
@@ -33,6 +39,7 @@ import android.platform.test.annotations.Presubmit; 
import android.service.gatekeeper.GateKeeperResponse;



import androidx.test.filters.SmallTest;

import androidx.test.runner.AndroidJUnit4;



import com.android.internal.widget.LockPatternUtils;

import com.android.internal.widget.LockscreenCredential;
@@ -40,47 +47,47 @@ import com.android.internal.widget.VerifyCredentialResponse; 
import com.android.server.locksettings.FakeGateKeeperService.VerifyHandle;

import com.android.server.locksettings.LockSettingsStorage.CredentialHash;



import org.junit.Test;

import org.junit.runner.RunWith;



/**

 * runtest frameworks-services -c com.android.server.locksettings.LockSettingsServiceTests

 * atest FrameworksServicesTests:LockSettingsServiceTests

 */

@SmallTest

@Presubmit

@RunWith(AndroidJUnit4.class)

public class LockSettingsServiceTests extends BaseLockSettingsServiceTests {



    @Override

    protected void setUp() throws Exception {

        super.setUp();

    }



    @Override

    protected void tearDown() throws Exception {

        super.tearDown();

    }



    @Test

    public void testCreatePasswordPrimaryUser() throws RemoteException {

        testCreateCredential(PRIMARY_USER_ID, newPassword("password"));

    }



    @Test

    public void testCreatePasswordFailsWithoutLockScreen() throws RemoteException {

        testCreateCredentialFailsWithoutLockScreen(PRIMARY_USER_ID, newPassword("password"));

    }



    @Test

    public void testCreatePatternPrimaryUser() throws RemoteException {

        testCreateCredential(PRIMARY_USER_ID, newPattern("123456789"));

    }



    @Test

    public void testCreatePatternFailsWithoutLockScreen() throws RemoteException {

        testCreateCredentialFailsWithoutLockScreen(PRIMARY_USER_ID, newPattern("123456789"));

    }



    @Test

    public void testChangePasswordPrimaryUser() throws RemoteException {

        testChangeCredentials(PRIMARY_USER_ID, newPattern("78963214"), newPassword("asdfghjk"));

    }



    @Test

    public void testChangePatternPrimaryUser() throws RemoteException {

        testChangeCredentials(PRIMARY_USER_ID, newPassword("!£$%^&*(())"), newPattern("1596321"));

    }



    @Test

    public void testChangePasswordFailPrimaryUser() throws RemoteException {

        final long sid = 1234;

        initializeStorageWithCredential(PRIMARY_USER_ID, newPassword("password"), sid);
@@ -90,6 +97,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
        assertVerifyCredentials(PRIMARY_USER_ID, newPassword("password"), sid);

    }



    @Test

    public void testClearPasswordPrimaryUser() throws RemoteException {

        initializeStorageWithCredential(PRIMARY_USER_ID, newPassword("password"), 1234);

        assertTrue(mService.setLockCredential(nonePassword(), newPassword("password"),
@@ -98,6 +106,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
        assertEquals(0, mGateKeeperService.getSecureUserId(PRIMARY_USER_ID));

    }



    @Test

    public void testManagedProfileUnifiedChallenge() throws RemoteException {

        final LockscreenCredential firstUnifiedPassword = newPassword("pwd-1");

        final LockscreenCredential secondUnifiedPassword = newPassword("pwd-2");
@@ -151,6 +160,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
        assertEquals(0, mGateKeeperService.getSecureUserId(TURNED_OFF_PROFILE_USER_ID));

    }



    @Test

    public void testManagedProfileSeparateChallenge() throws RemoteException {

        final LockscreenCredential primaryPassword = newPassword("primary");

        final LockscreenCredential profilePassword = newPassword("profile");
@@ -199,6 +209,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
        assertEquals(profileSid, mGateKeeperService.getSecureUserId(MANAGED_PROFILE_USER_ID));

    }



    @Test

    public void testSetLockCredential_forPrimaryUser_sendsCredentials() throws Exception {

        assertTrue(mService.setLockCredential(

                newPassword("password"),
@@ -211,6 +222,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
                        PRIMARY_USER_ID);

    }



    @Test

    public void testSetLockCredential_forProfileWithSeparateChallenge_sendsCredentials()

            throws Exception {

        assertTrue(mService.setLockCredential(
@@ -224,6 +236,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
                        MANAGED_PROFILE_USER_ID);

    }



    @Test

    public void testSetLockCredential_forProfileWithSeparateChallenge_updatesCredentials()

            throws Exception {

        initializeStorageWithCredential(
@@ -242,6 +255,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
                        MANAGED_PROFILE_USER_ID);

    }



    @Test

    public void testSetLockCredential_forProfileWithUnifiedChallenge_doesNotSendRandomCredential()

            throws Exception {

        mService.setSeparateProfileChallengeEnabled(MANAGED_PROFILE_USER_ID, false, null);
@@ -257,6 +271,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
                        eq(CREDENTIAL_TYPE_PASSWORD), any(), eq(MANAGED_PROFILE_USER_ID));

    }



    @Test

    public void

            testSetLockCredential_forPrimaryUserWithUnifiedChallengeProfile_updatesBothCredentials()

                    throws Exception {
@@ -280,6 +295,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
                        MANAGED_PROFILE_USER_ID);

    }



    @Test

    public void

            testSetLockCredential_forPrimaryUserWithUnifiedChallengeProfile_removesBothCredentials()

                    throws Exception {
@@ -298,6 +314,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
                .lockScreenSecretChanged(CREDENTIAL_TYPE_NONE, null, MANAGED_PROFILE_USER_ID);

    }



    @Test

    public void testSetLockCredential_nullCredential_removeBiometrics() throws RemoteException {

        initializeStorageWithCredential(

                PRIMARY_USER_ID,
@@ -315,6 +332,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
        verify(mFaceManager).remove(any(), eq(MANAGED_PROFILE_USER_ID), any());

    }



    @Test

    public void testSetLockCredential_forUnifiedToSeparateChallengeProfile_sendsNewCredentials()

            throws Exception {

        final LockscreenCredential parentPassword = newPassword("parentPassword");
@@ -333,6 +351,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
                        MANAGED_PROFILE_USER_ID);

    }



    @Test

    public void

            testSetLockCredential_forSeparateToUnifiedChallengeProfile_doesNotSendRandomCredential()

                    throws Exception {
@@ -351,6 +370,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
                .lockScreenSecretChanged(anyInt(), any(), eq(MANAGED_PROFILE_USER_ID));

    }



    @Test

    public void testVerifyCredential_forPrimaryUser_sendsCredentials() throws Exception {

        final LockscreenCredential password = newPassword("password");

        initializeStorageWithCredential(PRIMARY_USER_ID, password, 1234);
@@ -363,6 +383,7 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
                        CREDENTIAL_TYPE_PASSWORD, password.getCredential(), PRIMARY_USER_ID);

    }



    @Test

    public void testVerifyCredential_forProfileWithSeparateChallenge_sendsCredentials()

            throws Exception {

        final LockscreenCredential pattern = newPattern("12345");
@@ -380,8 +401,8 @@ public class LockSettingsServiceTests extends BaseLockSettingsServiceTests { 
                        CREDENTIAL_TYPE_PATTERN, pattern.getCredential(), MANAGED_PROFILE_USER_ID);

    }



    public void

            testVerifyCredential_forPrimaryUserWithUnifiedChallengeProfile_sendsCredentialsForBoth()

    @Test

    public void verifyCredential_forPrimaryUserWithUnifiedChallengeProfile_sendsCredentialsForBoth()

                    throws Exception {

        final LockscreenCredential pattern = newPattern("12345");

        initializeStorageWithCredential(PRIMARY_USER_ID, pattern, 1234);

services/tests/servicestests/src/com/android/server/locksettings/LockSettingsShellCommandTest.java

+1 −1
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ import static android.app.admin.DevicePolicyManager.PASSWORD_QUALITY_UNSPECIFIED 


import static junit.framework.Assert.assertEquals;



import static org.mockito.Matchers.anyInt;

import static org.mockito.ArgumentMatchers.anyInt;

import static org.mockito.Mockito.any;

import static org.mockito.Mockito.never;

import static org.mockito.Mockito.verify;

services/tests/servicestests/src/com/android/server/locksettings/LockSettingsStorageTests.java

+60 −18

File changed.

Preview size limit exceeded, changes collapsed.