Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6f93953 authored by Louis Pullen-Freilich's avatar Louis Pullen-Freilich
Browse files

Dark-greylists fill() methods in ListView and GridView 

These methods shouldn't be reflected on - and I'm not sure that there is
a valid reason for doing so. For anything more complex than what ListView /
GridView provide out of the box, developers should use and customize
RecyclerView.

Bug: b/123768638
Bug: b/123768419
Bug: b/123768563
Bug: b/123768501
Bug: b/123768701
Test: n/a
Change-Id: Ie13aa728832c085388322828320ba934415bd9e2
parent e8c4958b

core/java/android/widget/GridView.java

+2 −2
Original line number Diff line number Diff line
@@ -310,7 +310,7 @@ public class GridView extends AbsListView { 
     * @return The view that is currently selected, if it happens to be in the

     *         range that we draw.

     */

    @UnsupportedAppUsage

    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)

    private View fillDown(int pos, int nextTop) {

        View selectedView = null;
@@ -410,7 +410,7 @@ public class GridView extends AbsListView { 
     *

     * @return The view that is currently selected

     */

    @UnsupportedAppUsage

    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)

    private View fillUp(int pos, int nextBottom) {

        View selectedView = null;

core/java/android/widget/ListView.java

+3 −3
Original line number Diff line number Diff line
@@ -780,7 +780,7 @@ public class ListView extends AbsListView { 
     * @return The view that is currently selected, if it happens to be in the

     *         range that we draw.

     */

    @UnsupportedAppUsage

    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)

    private View fillDown(int pos, int nextTop) {

        View selectedView = null;
@@ -815,7 +815,7 @@ public class ListView extends AbsListView { 
     *

     * @return The view that is currently selected

     */

    @UnsupportedAppUsage

    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)

    private View fillUp(int pos, int nextBottom) {

        View selectedView = null;
@@ -1488,7 +1488,7 @@ public class ListView extends AbsListView { 
     * @return The selected view, or null if the selected view is outside the

     *         visible area.

     */

    @UnsupportedAppUsage

    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)

    private View fillSpecific(int position, int top) {

        boolean tempIsSelected = position == mSelectedPosition;

        View temp = makeAndAddView(position, top, true, mListPadding.left, tempIsSelected);