Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6f6e803 authored by Felipe Leme's avatar Felipe Leme
Browse files

Refactored UserRestrictionsUtilsTest to use list of expectations 

This refactoring will make it easier to add more tests for new
restrictions and/or arguments to the methods.

Bug: 424804763
Test: atest UserRestrictionsUtilsTest
Flag: TEST_ONLY

Change-Id: If0d9e5eebeec5bb4cc580377b6ae6a0de1c4adc0
parent b255f09d

services/tests/servicestests/src/com/android/server/pm/UserRestrictionsUtilsTest.java

+119 −80
Original line number Diff line number Diff line
@@ -25,17 +25,22 @@ import android.os.Bundle; 
import android.os.UserManager;

import android.platform.test.annotations.Presubmit;

import android.platform.test.flag.junit.SetFlagsRule;

import android.util.Pair;

import android.util.SparseArray;



import androidx.test.filters.SmallTest;

import androidx.test.runner.AndroidJUnit4;



import com.google.common.collect.ImmutableList;

import com.google.common.truth.Expect;



import org.junit.Rule;

import org.junit.Test;

import org.junit.runner.RunWith;



import java.util.Arrays;

import java.util.List;



/**

 * Tests for {@link com.android.server.pm.UserRestrictionsUtils}.

 *
@@ -48,6 +53,12 @@ import org.junit.runner.RunWith; 
@SmallTest

public final class UserRestrictionsUtilsTest {



    // List of restrictions applied to all methods

    private static final List<Pair<String, Boolean>> BASELINE_RESTRICTIONS = Arrays.asList(

            Pair.create(UserManager.DISALLOW_RECORD_AUDIO, false),

            Pair.create(UserManager.DISALLOW_WALLPAPER, false),

            Pair.create(UserManager.DISALLOW_ADJUST_VOLUME, true));



    @Rule

    public final Expect expect = Expect.create();
@@ -80,112 +91,140 @@ public final class UserRestrictionsUtilsTest { 
        assertThrows(IllegalArgumentException.class, () -> UserRestrictionsUtils.merge(a, a));

    }



    private static final List<Pair<String, Boolean>> CAN_DO_CHANGE =

            new ImmutableList.Builder<Pair<String, Boolean>>()

            .addAll(BASELINE_RESTRICTIONS)

            .add(Pair.create(UserManager.DISALLOW_ADD_USER, true))

            .add(Pair.create(UserManager.DISALLOW_USER_SWITCH, true))

            .build();



    @Test

    public void testCanDeviceOwnerChange() {

        expect.that(UserRestrictionsUtils.canDeviceOwnerChange(UserManager.DISALLOW_RECORD_AUDIO))

                .isFalse();

        expect.that(UserRestrictionsUtils.canDeviceOwnerChange(UserManager.DISALLOW_WALLPAPER))

                .isFalse();

        expect.that(UserRestrictionsUtils.canDeviceOwnerChange(UserManager.DISALLOW_ADD_USER))

                .isTrue();

        expect.that(UserRestrictionsUtils.canDeviceOwnerChange(UserManager.DISALLOW_USER_SWITCH))

                .isTrue();

        for (var pair : CAN_DO_CHANGE) {

            var key = pair.first;

            var expectedResult = pair.second;

            var result = UserRestrictionsUtils.canDeviceOwnerChange(key);

            expect.withMessage("canDeviceOwnerChange(%s)", key)

                    .that(result)

                    .isEqualTo(expectedResult);

        }

    }



    private static final List<Pair<String, Boolean>> CAN_PO_CHANGE__MAIN_USER =

            new ImmutableList.Builder<Pair<String, Boolean>>()

            .addAll(BASELINE_RESTRICTIONS)

            .add(Pair.create(UserManager.DISALLOW_ADD_USER, true))

            .add(Pair.create(UserManager.DISALLOW_USER_SWITCH, false))

            .build();



    @Test

    public void testCanProfileOwnerChange_mainUser() {

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_RECORD_AUDIO,

                /* isMainUser= */ true,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isFalse();

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_WALLPAPER,

                /* isMainUser= */ true,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isFalse();

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_USER_SWITCH,

                /* isMainUser= */ true,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isFalse();

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_ADD_USER,

        for (var pair : CAN_PO_CHANGE__MAIN_USER) {

            var key = pair.first;

            var expectedResult = pair.second;

            var result = UserRestrictionsUtils.canProfileOwnerChange(key,

                    /* isMainUser= */ true,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isTrue();

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_ADJUST_VOLUME,

                /* isMainUser= */ true,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isTrue();

                    /* isProfileOwnerOnOrgOwnedDevice= */ false);

            expect.withMessage("canProfileOwnerChange(%s)", key)

                    .that(result)

                    .isEqualTo(expectedResult);

        }

    }



    private static final List<Pair<String, Boolean>> CAN_PO_CHANGE__NOT_MAIN_USER =

            new ImmutableList.Builder<Pair<String, Boolean>>()

            .addAll(BASELINE_RESTRICTIONS)

            .add(Pair.create(UserManager.DISALLOW_ADD_USER, false))

            .add(Pair.create(UserManager.DISALLOW_USER_SWITCH, false))

            .build();



    @Test

    public void testCanProfileOwnerChange_notMainUser() {

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_RECORD_AUDIO,

                /* isMainUser= */ false,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isFalse();

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_WALLPAPER,

                /* isMainUser= */ false,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isFalse();

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_ADD_USER,

        for (var pair : CAN_PO_CHANGE__NOT_MAIN_USER) {

            var key = pair.first;

            var expectedResult = pair.second;

            var result = UserRestrictionsUtils.canProfileOwnerChange(key,

                    /* isMainUser= */ false,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isFalse();

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_USER_SWITCH,

                /* isMainUser= */ false,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isFalse();

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_ADJUST_VOLUME,

                /* isMainUser= */ false,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isTrue();

                    /* isProfileOwnerOnOrgOwnedDevice= */ false);

            expect.withMessage("canProfileOwnerChange(%s)", key)

                    .that(result)

                    .isEqualTo(expectedResult);

        }

    }



    // These restrictions are only allowed when isProfileOwnerOnOrgOwnedDevice is true, regardless

    // of the other arguments

    private static final String[] CAN_PO_CHANGE__ALWAYS_REQUIRES_ORG_OWNER = {

            UserManager.DISALLOW_SIM_GLOBALLY,

    };



    @Test

    public void testCanProfileOwnerChange_restrictionRequiresOrgOwnedDevice_orgOwned() {

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_SIM_GLOBALLY,

        for (String key: CAN_PO_CHANGE__ALWAYS_REQUIRES_ORG_OWNER) {

            expect.withMessage("canProfileOwnerChange(%s, notMainUser, orgOwned)", key)

                    .that(UserRestrictionsUtils.canProfileOwnerChange(key,

                            /* isMainUser= */ false,

                /* isProfileOwnerOnOrgOwnedDevice= */                 true)).isTrue();

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_SIM_GLOBALLY,

                            /* isProfileOwnerOnOrgOwnedDevice= */ true))

                    .isTrue();

            expect.withMessage("canProfileOwnerChange(%s, mainUser, orgOwned)", key)

                    .that(UserRestrictionsUtils.canProfileOwnerChange(key,

                            /* isMainUser= */ true,

                /* isProfileOwnerOnOrgOwnedDevice= */ true)).isTrue();

                            /* isProfileOwnerOnOrgOwnedDevice= */ true))

                    .isTrue();

        }

    }



    @Test

    public void testCanProfileOwnerChange_restrictionRequiresOrgOwnedDevice_notOrgOwned() {

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_SIM_GLOBALLY,

        for (String key: CAN_PO_CHANGE__ALWAYS_REQUIRES_ORG_OWNER) {

            expect.withMessage("canProfileOwnerChange(%s, notMainUser, notOrgOwned)", key)

                    .that(UserRestrictionsUtils.canProfileOwnerChange(key,

                            /* isMainUser= */ false,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isFalse();

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_SIM_GLOBALLY,

                            /* isProfileOwnerOnOrgOwnedDevice= */ false))

                    .isFalse();

            expect.withMessage("canProfileOwnerChange(%s, mainUser, notOrgOwned)", key)

                    .that(UserRestrictionsUtils.canProfileOwnerChange(key,

                            /* isMainUser= */ true,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isFalse();

                            /* isProfileOwnerOnOrgOwnedDevice= */ false))

                    .isFalse();

        }

    }



    // These restrictions are allowed regardless of the arguments

    private static final String[] CAN_PO_CHANGE__DONT_REQUIRES_ORG_OWNER = {

            UserManager.DISALLOW_ADJUST_VOLUME,

    };



    @Test

    public void testCanProfileOwnerChange_restrictionNotRequiresOrgOwnedDevice_orgOwned() {

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_ADJUST_VOLUME,

        for (String key: CAN_PO_CHANGE__DONT_REQUIRES_ORG_OWNER) {

            expect.withMessage("canProfileOwnerChange(%s, notMainUser, orgOwned)", key)

                    .that(UserRestrictionsUtils.canProfileOwnerChange(key,

                            /* isMainUser= */ false,

                /* isProfileOwnerOnOrgOwnedDevice= */ true)).isTrue();

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_ADJUST_VOLUME,

                            /* isProfileOwnerOnOrgOwnedDevice= */ true))

                    .isTrue();

            expect.withMessage("canProfileOwnerChange(%s, mainUser, orgOwned)", key)

                    .that(UserRestrictionsUtils.canProfileOwnerChange(key,

                            /* isMainUser= */ true,

                /* isProfileOwnerOnOrgOwnedDevice= */ true)).isTrue();

                            /* isProfileOwnerOnOrgOwnedDevice= */ true))

                    .isTrue();

        }

    }



    @Test

    public void testCanProfileOwnerChange_restrictionNotRequiresOrgOwnedDevice_notOrgOwned() {

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_ADJUST_VOLUME,

        for (String key: CAN_PO_CHANGE__DONT_REQUIRES_ORG_OWNER) {

            expect.withMessage("canProfileOwnerChange(%s, notMainUser, notOrgOwned)", key)

                    .that(UserRestrictionsUtils.canProfileOwnerChange(key,

                            /* isMainUser= */ false,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isTrue();

        expect.that(UserRestrictionsUtils.canProfileOwnerChange(

                UserManager.DISALLOW_ADJUST_VOLUME,

                            /* isProfileOwnerOnOrgOwnedDevice= */ false))

                    .isTrue();

            expect.withMessage("canProfileOwnerChange(%s, mainUser, notOrgOwned)", key)

                    .that(UserRestrictionsUtils.canProfileOwnerChange(key,

                            /* isMainUser= */ true,

                /* isProfileOwnerOnOrgOwnedDevice= */ false)).isTrue();

                            /* isProfileOwnerOnOrgOwnedDevice= */ false))

                    .isTrue();

        }

    }



    @Test