Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e688bf72 authored by Chris Craik's avatar Chris Craik
Browse files

Constrain drawBitmap matrix-to-rect optimization 

bug:22962165

Optimization is not valid if matrix would flip image.

Change-Id: Ieee42390517bd3466b7d94596f0fbbe192ab757e
parent f2cb6f7e

libs/hwui/DisplayListCanvas.cpp

+3 −1
Original line number Diff line number Diff line
@@ -255,7 +255,9 @@ void DisplayListCanvas::drawBitmap(const SkBitmap& bitmap, const SkMatrix& matri 
        const SkPaint* paint) {

    if (matrix.isIdentity()) {

        drawBitmap(&bitmap, paint);

    } else if (!(matrix.getType() & ~(SkMatrix::kScale_Mask | SkMatrix::kTranslate_Mask))) {

    } else if (!(matrix.getType() & ~(SkMatrix::kScale_Mask | SkMatrix::kTranslate_Mask))

            && MathUtils::isPositive(matrix.getScaleX())

            && MathUtils::isPositive(matrix.getScaleY())) {

        // SkMatrix::isScaleTranslate() not available in L

        SkRect src;

        SkRect dst;