Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6418f26 authored by Sally's avatar Sally
Browse files

Fix bold text bug in NumberPicker 

To draw its numbers, NumberPicker is using the original typeface of its
input TextView. This gets the wrong Typeface if bold text is enabled.

Fix this by using the TextView's TextPaint typeface. (This TextPaint is
never null).

See videos in bug for before and after comparisons.

Bug: 318304896
Test: manual
Flag: android.widget.flags.fix_unbolded_typeface_for_numberpicker
Change-Id: I9b45738291d6e8a12693dc02d2c3e32ac5952aec
parent 281e0372

core/java/android/widget/NumberPicker.java

+6 −1
Original line number Diff line number Diff line
@@ -59,6 +59,7 @@ import android.view.accessibility.AccessibilityNodeProvider; 
import android.view.animation.DecelerateInterpolator;

import android.view.inputmethod.EditorInfo;

import android.view.inputmethod.InputMethodManager;

import android.widget.flags.Flags;



import com.android.internal.R;
@@ -790,7 +791,11 @@ public class NumberPicker extends LinearLayout { 
        paint.setAntiAlias(true);

        paint.setTextAlign(Align.CENTER);

        paint.setTextSize(mTextSize);

        if (Flags.fixUnboldedTypefaceForNumberpicker()) {

            paint.setTypeface(mInputText.getPaint().getTypeface());

        } else {

            paint.setTypeface(mInputText.getTypeface());

        }

        ColorStateList colors = mInputText.getTextColors();

        int color = colors.getColorForState(ENABLED_STATE_SET, Color.WHITE);

        paint.setColor(color);

core/java/android/widget/flags/flags.aconfig

+10 −0
Original line number Diff line number Diff line
@@ -17,3 +17,13 @@ flag { 
  is_exported: true

  bug: "369480667"

}



flag {

  name: "fix_unbolded_typeface_for_numberpicker"

  namespace: "text"

  description: "Use the correct bolded typeface when drawing the selector numbers"

  bug: "318304896"

  metadata {

    purpose: PURPOSE_BUGFIX

  }

}