Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e622c1f0 authored by Alex Light's avatar Alex Light
Browse files

Revert^2 "Update boot image and system server profiles [M5C5P90S0PP]"

This reverts commit 3ca06124.
This unreverts commit 740d4947.

= Perf stats =
(lower is better)

Start and memory are improving at a slight expense of code size and
boot time. The boot time metric is very noisy however. This changes
adds inline-caches to the boot profile.

An inline cache is formatted like:

```
HSPLthis/is/a/classMethod;->descriptor()V+]Ltarget/type;Lresult/type1;,Lresult/type2;]Ltarget/type2;megamorphic_types
HSPLandroid/content/pm/parsing/ParsingPackageUtils;->hasDomainURLs(Landroid/content/pm/parsing/ParsingPackage;)Z+]Landroid/content/pm/parsing/component/ParsedActivity;Landroid/content/pm/parsing/component/ParsedActivity;]Ljava/util/List;Ljava/util/Collections$EmptyList;,Ljava/util/ArrayList;]Landroid/content/pm/parsing/component/ParsedIntentInfo;Landroid/content/pm/parsing/component/ParsedIntentInfo;
```

Cold startup (speed-profile): -2.35%
PSS: -1.60%
RSS: -0.44%
Private Dirty: -2.14%
Boot time: +3.24%
Code size: +5.83%


=Generation Strategy=

method_threshold: 0.05
image_class_threshold: 0.05
preloaded_classes_threshold: 0.9
upgrade_startup_methods_to_hot: true
system_server_threshold: 0.0
priority_packages_thresholds {
  key: "android"
  value: 0.02
}
priority_packages_thresholds {
  key: "com.android.systemui"
  value: 0.02
}
priority_packages_thresholds {
  key: "com.google.android.GoogleCamera"
  value: 0.02
}
priority_packages_thresholds {
  key: "com.google.android.webview"
  value: 0.02
}

=Profile stats=

Data info:
- total aggregations: 4247
- number of (device types, builds): 128

File boot-image-profile.txt
  - hot methods: 7863 added, 8398 removed
  - methods: 7857 added, 8398 removed
  - classes: 352 added, 848 removed
  - totals now: 28221 hot methods, 28225 methods, 15214 classes
  - totals before: 28756 hot methods, 28766 methods, 15710 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 3992, 4543, 246, 358, 18011, 9330
    com.android, 590, 593, 96, 429, 2051, 3192
    java, 2521, 2494, 9, 59, 6493, 1748
    android.view, 729, 805, 15, 74, 2704, 796
    android.hardware, 36, 43, 16, 8, 312, 787
    android.bluetooth, 12, 10, 0, 1, 148, 169
    android.animation, 99, 106, 0, 0, 346, 71
    android.app, 415, 493, 24, 48, 2438, 942
    android.content, 400, 462, 14, 22, 1760, 567
    android.graphics, 321, 393, 2, 19, 1691, 303
    android.icu, 489, 424, 58, 4, 1758, 1528
    android.media, 61, 91, 4, 19, 648, 553
    android.net, 134, 157, 27, 15, 633, 410
    android.widget, 307, 382, 11, 16, 1196, 352

File preloaded-classes
  - hot methods: 0 added, 0 removed
  - methods: 0 added, 0 removed
  - classes: 5 added, 474 removed
  - totals now: 0 hot methods, 0 methods, 13974 classes
  - totals before: 0 hot methods, 0 methods, 14443 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 0, 0, 5, 121, 0, 8524
    com.android, 0, 0, 0, 308, 0, 2804
    java, 0, 0, 0, 43, 0, 1714
    android.view, 0, 0, 0, 11, 0, 743
    android.hardware, 0, 0, 0, 1, 0, 679
    android.app, 0, 0, 0, 29, 0, 865
    android.content, 0, 0, 0, 4, 0, 515
    android.graphics, 0, 0, 0, 8, 0, 295
    android.icu, 0, 0, 0, 4, 0, 1468
    android.media, 0, 0, 0, 3, 0, 499
    android.net, 0, 0, 4, 1, 0, 342
    android.widget, 0, 0, 0, 5, 0, 329

File art-profile
  - hot methods: 15265 added, 13296 removed
  - methods: 18373 added, 16318 removed
  - classes: 490 added, 1810 removed
  - totals now: 29686 hot methods, 44370 methods, 4807 classes
  - totals before: 27717 hot methods, 42315 methods, 6127 classes

  per package info as csv (selected):
    package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
    android, 185, 140, 10, 14, 459, 283
    com.android, 15050, 13109, 480, 1788, 29089, 4482
    android.hardware, 101, 69, 9, 6, 242, 127
    android.app, 0, 0, 0, 0, 1, 3
    android.content, 1, 0, 0, 0, 2, 6
    android.net, 80, 68, 0, 8, 192, 131

InternalReferenceRawProfileId: 3661
InternalReferenceCandidateProfileId: 3664


Reason for revert: Underlying issue causing build failures fixed in ART
Bug: 168941430
Bug: 183514504
Test: build & benchmark

Change-Id: Icf870c90dd68b8450ad0928ae8e5594c5eb94423
parent 3ca06124
Loading
Loading
Loading
Loading
+8218 −9255

File changed.

Preview size limit exceeded, changes collapsed.

+5 −474

File changed.

Preview size limit exceeded, changes collapsed.

+21316 −20581

File changed.

Preview size limit exceeded, changes collapsed.