Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e5224a79 authored by Biswarup Pal's avatar Biswarup Pal
Browse files

Incorporate calling userId for ViewConfiguration resource overlays 

OverlayManager enables overlays for a given user, and we need to pass the calling user id, otherwise it will default to the system user, and not the calling user (which are different on HSUM devices).

Test: atest VirtualDeviceViewConfigurationTest on HSUM
Flag: EXEMPT bugfix
Fixes: 410745011
Change-Id: Icb8a61868772c25dd43743e2969e6432227c4061
parent 41e374ba

services/companion/java/com/android/server/companion/virtual/ViewConfigurationController.java

+2 −1
Original line number Diff line number Diff line
@@ -96,11 +96,12 @@ public class ViewConfigurationController { 
        setResourceIntValue(overlay, DOUBLE_TAP_MIN_TIME_RESOURCE_NAME,

                (int) viewConfigurationParams.getDoubleTapMinTimeDuration().toMillis());



        int callingUserId = Binder.getCallingUserHandle().getIdentifier();

        Binder.withCleanCallingIdentity(() -> {

            mOverlayManager.commit(

                    new OverlayManagerTransaction.Builder()

                            .registerFabricatedOverlay(overlay)

                            .setEnabled(overlayIdentifier, true /* enable */,

                            .setEnabled(overlayIdentifier, true /* enable */, callingUserId,

                                    List.of(new OverlayConstraint(OverlayConstraint.TYPE_DEVICE_ID,

                                            deviceId)))

                            .build());