Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e48e6dac authored by John Reck's avatar John Reck
Browse files

Don't create string temporaries if tracing isn't enabled 

Test: none
Change-Id: I82212c7b49c1c79bccd48e8d98326253372a6b62
parent 6f8b97e0

core/java/android/app/ActivityThread.java

+8 −2
Original line number Diff line number Diff line
@@ -1871,7 +1871,10 @@ public final class ActivityThread extends ClientTransactionHandler { 
                    Trace.traceEnd(Trace.TRACE_TAG_ACTIVITY_MANAGER);

                    break;

                case CREATE_SERVICE:

                    Trace.traceBegin(Trace.TRACE_TAG_ACTIVITY_MANAGER, ("serviceCreate: " + String.valueOf(msg.obj)));

                    if (Trace.isTagEnabled(Trace.TRACE_TAG_ACTIVITY_MANAGER)) {

                        Trace.traceBegin(Trace.TRACE_TAG_ACTIVITY_MANAGER,

                                ("serviceCreate: " + String.valueOf(msg.obj)));

                    }

                    handleCreateService((CreateServiceData)msg.obj);

                    Trace.traceEnd(Trace.TRACE_TAG_ACTIVITY_MANAGER);

                    break;
@@ -1887,7 +1890,10 @@ public final class ActivityThread extends ClientTransactionHandler { 
                    Trace.traceEnd(Trace.TRACE_TAG_ACTIVITY_MANAGER);

                    break;

                case SERVICE_ARGS:

                    Trace.traceBegin(Trace.TRACE_TAG_ACTIVITY_MANAGER, ("serviceStart: " + String.valueOf(msg.obj)));

                    if (Trace.isTagEnabled(Trace.TRACE_TAG_ACTIVITY_MANAGER)) {

                        Trace.traceBegin(Trace.TRACE_TAG_ACTIVITY_MANAGER,

                                ("serviceStart: " + String.valueOf(msg.obj)));

                    }

                    handleServiceArgs((ServiceArgsData)msg.obj);

                    Trace.traceEnd(Trace.TRACE_TAG_ACTIVITY_MANAGER);

                    break;