Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e48d0ae6 authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Remove IInputMethodManager#finishInput(), which is NOP 

Currently InputMethodManagerService#finishInput() does nothing. Until
we fully understand what is the right approach on how and when
InputMethodService#finishInput() (Bug 9216494), let's remove this
unnecessary IPC from the IME client to InputMethodManagerService.

Bug: 9216494
Test: atest CtsInputMethodTestCases CtsInputMethodServiceHostTestCases
Test: atest FrameworksCoreTests:android.view.inputmethod.InputMethodManagerTest
Change-Id: I614050d20f4a7d9611dc0502e55e6ca3458a836e
parent 6ea57e1b

core/java/android/view/inputmethod/InputMethodManager.java

+0 −7
Original line number Diff line number Diff line
@@ -1052,13 +1052,6 @@ public final class InputMethodManager { 
        mNextServedView = null;

        if (mServedView != null) {

            if (DEBUG) Log.v(TAG, "FINISH INPUT: mServedView=" + dumpViewInfo(mServedView));

            if (mCurrentTextBoxAttribute != null) {

                try {

                    mService.finishInput(mClient);

                } catch (RemoteException e) {

                    throw e.rethrowFromSystemServer();

                }

            }

            mServedView = null;

            mCompletions = null;

            mServedConnecting = false;

core/java/com/android/internal/view/IInputMethodManager.aidl

+0 −1
Original line number Diff line number Diff line
@@ -46,7 +46,6 @@ interface IInputMethodManager { 
    // Currently there is a bug that aidl doesn't accept List<Parcelable>

    List getShortcutInputMethodsAndSubtypes();



    void finishInput(in IInputMethodClient client);

    boolean showSoftInput(in IInputMethodClient client, int flags,

            in ResultReceiver resultReceiver);

    boolean hideSoftInput(in IInputMethodClient client, int flags,

services/core/java/com/android/server/inputmethod/InputMethodManagerService.java

+0 −4
Original line number Diff line number Diff line
@@ -2014,10 +2014,6 @@ public class InputMethodManagerService extends IInputMethodManager.Stub 
        return InputBindResult.IME_NOT_CONNECTED;

    }



    @Override

    public void finishInput(IInputMethodClient client) {

    }



    @Override

    public void onServiceConnected(ComponentName name, IBinder service) {

        synchronized (mMethodMap) {