Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e436e4f8 authored by Robert Greenwalt's avatar Robert Greenwalt
Browse files

Remove two new permission checks 

These checks while technically reasonable are a hard to swallow API change
that may break existing apps and pragmatically serves no purpose:  the protected
data is available in publicly readable java VM properties.

Change-Id: I522c493c2604a33e28d99e2be31054326c9a8323
parent ea53d7e0

services/java/com/android/server/ConnectivityService.java

+8 −2
Original line number Diff line number Diff line
@@ -2999,7 +2999,10 @@ public class ConnectivityService extends IConnectivityManager.Stub { 
    }



    public ProxyProperties getProxy() {

        enforceAccessPermission();

        // this information is already available as a world read/writable jvm property

        // so this API change wouldn't have a benifit.  It also breaks the passing

        // of proxy info to all the JVMs.

        // enforceAccessPermission();

        synchronized (mDefaultProxyLock) {

            return mDefaultProxyDisabled ? null : mDefaultProxy;

        }
@@ -3051,7 +3054,10 @@ public class ConnectivityService extends IConnectivityManager.Stub { 
    }



    public ProxyProperties getGlobalProxy() {

        enforceAccessPermission();

        // this information is already available as a world read/writable jvm property

        // so this API change wouldn't have a benifit.  It also breaks the passing

        // of proxy info to all the JVMs.

        // enforceAccessPermission();

        synchronized (mGlobalProxyLock) {

            return mGlobalProxy;

        }