Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3f0818b authored by Andres Morales's avatar Andres Morales
Browse files

check for null members in NotifyHandler 

An unexpected message posted to the queue should not
crash the application.

Bug: 27097094
Change-Id: Ide6a07014660ff14e0f287660c534cfa1e0acad9
parent 910beb8f

core/jni/android_view_ThreadedRenderer.cpp

+5 −1
Original line number Diff line number Diff line
@@ -322,7 +322,11 @@ private: 
void NotifyHandler::handleMessage(const Message& message) {

    JNIEnv* env = getenv(mVm);



    jobject target = env->NewLocalRef(mObserver->getObserverReference());

    ObserverProxy* observer = mObserver.get();

    LOG_ALWAYS_FATAL_IF(observer == nullptr, "received message with no observer configured");

    LOG_ALWAYS_FATAL_IF(mBuffer == nullptr, "received message with no data to report");



    jobject target = env->NewLocalRef(observer->getObserverReference());



    if (target != nullptr) {

        jlongArray javaBuffer = get_metrics_buffer(env, target);