Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3d8a1a2 authored by Bernardo Rufino's avatar Bernardo Rufino
Browse files

Deprecate unsafe Parcel.readParcelableArray(ClassLoader) 

Forgot this one.

Test: Builds
Bug: 195622897
Change-Id: Ia258f77fd2e706d2071c853c20d6ec3baa170a1f
parent 36cf3994

core/api/current.txt

+1 −1
Original line number Diff line number Diff line
@@ -31480,7 +31480,7 @@ package android.os { 
    method public <K, V> void readMap(@NonNull java.util.Map<? super K,? super V>, @Nullable ClassLoader, @NonNull Class<K>, @NonNull Class<V>);

    method @Deprecated @Nullable public <T extends android.os.Parcelable> T readParcelable(@Nullable ClassLoader);

    method @Nullable public <T extends android.os.Parcelable> T readParcelable(@Nullable ClassLoader, @NonNull Class<T>);

    method @Nullable public android.os.Parcelable[] readParcelableArray(@Nullable ClassLoader);

    method @Deprecated @Nullable public android.os.Parcelable[] readParcelableArray(@Nullable ClassLoader);

    method @Nullable public <T> T[] readParcelableArray(@Nullable ClassLoader, @NonNull Class<T>);

    method @Deprecated @Nullable public android.os.Parcelable.Creator<?> readParcelableCreator(@Nullable ClassLoader);

    method @Nullable public <T> android.os.Parcelable.Creator<T> readParcelableCreator(@Nullable ClassLoader, @NonNull Class<T>);

core/java/android/os/Parcel.java

+8 −1
Original line number Diff line number Diff line
@@ -4343,9 +4343,16 @@ public final class Parcel { 
     * The given class loader will be used to load any enclosed

     * Parcelables.

     * @return the Parcelable array, or null if the array is null

     *

     * @deprecated Use the type-safer version {@link #readParcelableArray(ClassLoader, Class)}

     *      starting from Android {@link Build.VERSION_CODES#TIRAMISU}. Also consider changing the

     *      format to use {@link #createTypedArray(Parcelable.Creator)} if possible (eg. if the

     *      items' class is final) since this is also more performant. Note that changing to the

     *      latter also requires changing the writes.

     */

    @Deprecated

    @Nullable

    public final Parcelable[] readParcelableArray(@Nullable ClassLoader loader) {

    public Parcelable[] readParcelableArray(@Nullable ClassLoader loader) {

        int N = readInt();

        if (N < 0) {

            return null;