Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e37f13f3 authored by Weilin Xu's avatar Weilin Xu
Browse files

Add more tests for program list and radio manager 

Added more unit tests for program list and radio manager. Reduced
timeout value for tuner adapter unit tests to 500 ms. Used mocked
context instead to remove InstrumentationRegistry from program
list unit test.

Bug: 262583864
Test: atest android.hardware.radio
Change-Id: I4c09f82ff1a59b6331d4d036f8b34c447b1fe36b
parent 6b31e41e

core/tests/BroadcastRadioTests/src/android/hardware/radio/ProgramListTest.java

+94 −8
Original line number Diff line number Diff line
@@ -22,19 +22,22 @@ import static org.junit.Assert.assertThrows; 
import static org.mockito.ArgumentMatchers.any;

import static org.mockito.ArgumentMatchers.anyBoolean;

import static org.mockito.ArgumentMatchers.anyInt;

import static org.mockito.Mockito.after;

import static org.mockito.Mockito.doAnswer;

import static org.mockito.Mockito.doThrow;

import static org.mockito.Mockito.mock;

import static org.mockito.Mockito.never;

import static org.mockito.Mockito.timeout;

import static org.mockito.Mockito.verify;

import static org.mockito.Mockito.when;



import android.content.Context;

import android.content.pm.ApplicationInfo;

import android.os.Build;

import android.os.Parcel;

import android.os.RemoteException;

import android.util.ArraySet;



import androidx.test.InstrumentationRegistry;



import org.junit.Test;

import org.junit.runner.RunWith;

import org.mockito.Mock;
@@ -48,10 +51,11 @@ import java.util.concurrent.Executor; 
@RunWith(MockitoJUnitRunner.class)

public final class ProgramListTest {



    public final Context mContext = InstrumentationRegistry.getContext();

    private static final int TEST_TARGET_SDK_VERSION = Build.VERSION_CODES.CUR_DEVELOPMENT;



    private static final int CREATOR_ARRAY_SIZE = 3;

    private static final VerificationWithTimeout CALLBACK_TIMEOUT = timeout(/* millis= */ 500);

    private static final int TIMEOUT_MS = 500;

    private static final VerificationWithTimeout CALLBACK_TIMEOUT = timeout(TIMEOUT_MS);



    private static final boolean IS_PURGE = false;

    private static final boolean IS_COMPLETE = true;
@@ -95,6 +99,7 @@ public final class ProgramListTest { 
            command.run();

        }

    };

    private final ApplicationInfo mApplicationInfo = new ApplicationInfo();



    private RadioTuner mRadioTuner;

    private ITunerCallback mTunerCallback;
@@ -103,6 +108,8 @@ public final class ProgramListTest { 
    private ProgramList.ListCallback[] mListCallbackMocks;

    private ProgramList.OnCompleteListener[] mOnCompleteListenerMocks;

    @Mock

    private Context mContextMock;

    @Mock

    private IRadioService mRadioServiceMock;

    @Mock

    private ITuner mTunerMock;
@@ -267,6 +274,18 @@ public final class ProgramListTest { 
        assertWithMessage("Chunks").that(chunks).hasLength(CREATOR_ARRAY_SIZE);

    }



    @Test

    public void getProgramList_forTunerAdapterWhenListNotReady_fails() throws Exception {

        Map<String, String> parameters = Map.of("ParameterKeyMock", "ParameterValueMock");

        createRadioTuner();



        IllegalStateException thrown = assertThrows(IllegalStateException.class,

                () -> mRadioTuner.getProgramList(parameters));



        assertWithMessage("Exception for getting program list when not ready")

                .that(thrown).hasMessageThat().contains("Program list is not ready yet");

    }



    @Test

    public void getProgramList_forTunerAdapterWhenServiceDied_fails() throws Exception {

        Map<String, String> parameters = Map.of("ParameterKeyMock", "ParameterValueMock");
@@ -289,6 +308,19 @@ public final class ProgramListTest { 
        verify(mTunerMock).startProgramListUpdates(TEST_FILTER);

    }



    @Test

    public void getDynamicProgramList_forTunerNotSupportingProgramList_returnsNull()

            throws Exception {

        createRadioTuner();

        doThrow(new UnsupportedOperationException())

                .when(mTunerMock).startProgramListUpdates(any());



        ProgramList nullProgramList = mRadioTuner.getDynamicProgramList(TEST_FILTER);



        assertWithMessage("Exception for radio HAL client not supporting program list")

                .that(nullProgramList).isNull();

    }



    @Test

    public void getDynamicProgramList_forTunerAdapterWithServiceDied_throwsException()

            throws Exception {
@@ -346,7 +378,7 @@ public final class ProgramListTest { 


        mTunerCallback.onProgramListUpdated(FM_ADD_INCOMPLETE_CHUNK);



        verify(mOnCompleteListenerMocks[0], CALLBACK_TIMEOUT.times(0)).onComplete();

        verify(mOnCompleteListenerMocks[0], after(TIMEOUT_MS).never()).onComplete();

    }



    @Test
@@ -366,6 +398,22 @@ public final class ProgramListTest { 
                .that(mProgramList.toList()).isEmpty();

    }



    @Test

    public void onProgramListUpdated_afterProgramListClosed_notInvokeMockedCallbacks()

            throws Exception {

        createRadioTuner();

        mProgramList = mRadioTuner.getDynamicProgramList(TEST_FILTER);

        registerListCallbacks(/* numCallbacks= */ 1);

        addOnCompleteListeners(/* numListeners= */ 1);

        mProgramList.close();



        mTunerCallback.onProgramListUpdated(FM_RDS_ADD_CHUNK);



        verify(mListCallbackMocks[0], after(TIMEOUT_MS).never()).onItemChanged(any());

        verify(mListCallbackMocks[0], never()).onItemChanged(any());

        verify(mOnCompleteListenerMocks[0], never()).onComplete();

    }



    @Test

    public void onItemChanged_forListCallbackRegisteredWithExecutor_invokesWhenIdAdded()

            throws Exception {
@@ -409,6 +457,41 @@ public final class ProgramListTest { 
        }

    }



    @Test

    public void onBackgroundScanComplete_whenProgramListReady_invokesMockedCallback()

            throws Exception {

        createRadioTuner();

        mProgramList = mRadioTuner.getDynamicProgramList(TEST_FILTER);

        mTunerCallback.onProgramListUpdated(FM_RDS_ADD_CHUNK);



        mTunerCallback.onBackgroundScanComplete();



        verify(mTunerCallbackMock, CALLBACK_TIMEOUT).onBackgroundScanComplete();

    }



    @Test

    public void onBackgroundScanComplete_whenProgramListNotReady_notInvokeMockedCallback()

            throws Exception {

        createRadioTuner();

        mProgramList = mRadioTuner.getDynamicProgramList(TEST_FILTER);



        mTunerCallback.onBackgroundScanComplete();



        verify(mTunerCallbackMock, after(TIMEOUT_MS).never()).onBackgroundScanComplete();

    }



    @Test

    public void onBackgroundScanComplete_afterProgramListReady_invokesMockedCallback()

            throws Exception {

        createRadioTuner();

        mProgramList = mRadioTuner.getDynamicProgramList(TEST_FILTER);



        mTunerCallback.onBackgroundScanComplete();

        mTunerCallback.onProgramListUpdated(FM_RDS_ADD_CHUNK);



        verify(mTunerCallbackMock, CALLBACK_TIMEOUT).onBackgroundScanComplete();

    }



    @Test

    public void unregisterListCallback_withProgramUpdated_notInvokesCallback() throws Exception {

        createRadioTuner();
@@ -418,7 +501,7 @@ public final class ProgramListTest { 
        mProgramList.unregisterListCallback(mListCallbackMocks[0]);

        mTunerCallback.onProgramListUpdated(FM_ADD_INCOMPLETE_CHUNK);



        verify(mListCallbackMocks[0], CALLBACK_TIMEOUT.times(0)).onItemChanged(any());

        verify(mListCallbackMocks[0], after(TIMEOUT_MS).never()).onItemChanged(any());

    }



    @Test
@@ -457,7 +540,7 @@ public final class ProgramListTest { 
        mProgramList.removeOnCompleteListener(mOnCompleteListenerMocks[0]);

        mTunerCallback.onProgramListUpdated(FM_RDS_ADD_CHUNK);



        verify(mOnCompleteListenerMocks[0], CALLBACK_TIMEOUT.times(0)).onComplete();

        verify(mOnCompleteListenerMocks[0], after(TIMEOUT_MS).never()).onComplete();

    }



    @Test
@@ -484,7 +567,10 @@ public final class ProgramListTest { 
    }



    private void createRadioTuner() throws Exception {

        RadioManager radioManager = new RadioManager(mContext, mRadioServiceMock);

        mApplicationInfo.targetSdkVersion = TEST_TARGET_SDK_VERSION;

        when(mContextMock.getApplicationInfo()).thenReturn(mApplicationInfo);

        RadioManager radioManager = new RadioManager(mContextMock, mRadioServiceMock);



        RadioManager.BandConfig band = new RadioManager.FmBandConfig(

                new RadioManager.FmBandDescriptor(RadioManager.REGION_ITU_1, RadioManager.BAND_FM,

                        /* lowerLimit= */ 87500, /* upperLimit= */ 108000, /* spacing= */ 200,

core/tests/BroadcastRadioTests/src/android/hardware/radio/RadioManagerTest.java

+6 −0
Original line number Diff line number Diff line
@@ -776,6 +776,12 @@ public final class RadioManagerTest { 
                .that(AMFM_PROPERTIES.describeContents()).isEqualTo(0);

    }



    @Test

    public void toString_forModuleProperties() {

        assertWithMessage("Module properties string").that(AMFM_PROPERTIES.toString())

                .contains(AM_BAND_DESCRIPTOR.toString() + ", " + FM_BAND_DESCRIPTOR.toString());

    }



    @Test

    public void writeToParcel_forModulePropertiesWithNullDabFrequencyTable() {

        Parcel parcel = Parcel.obtain();

core/tests/BroadcastRadioTests/src/android/hardware/radio/TunerAdapterTest.java

+20 −2
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ import static org.mockito.ArgumentMatchers.any; 
import static org.mockito.ArgumentMatchers.anyBoolean;

import static org.mockito.ArgumentMatchers.anyInt;

import static org.mockito.ArgumentMatchers.eq;

import static org.mockito.Mockito.after;

import static org.mockito.Mockito.doAnswer;

import static org.mockito.Mockito.doThrow;

import static org.mockito.Mockito.timeout;
@@ -51,7 +52,7 @@ public final class TunerAdapterTest { 


    private static final int TEST_TARGET_SDK_VERSION = Build.VERSION_CODES.CUR_DEVELOPMENT;



    private static final int CALLBACK_TIMEOUT_MS = 30_000;

    private static final int CALLBACK_TIMEOUT_MS = 500;

    private static final int AM_LOWER_LIMIT_KHZ = 150;



    private static final RadioManager.BandConfig TEST_BAND_CONFIG = createBandConfig();
@@ -445,7 +446,17 @@ public final class TunerAdapterTest { 
    }



    @Test

    public void getProgramInfo_beforeProgramInfoSetForTunerAdapter() {

    public void getProgramInfo_withInvalidInput_fails() {

        RadioManager.ProgramInfo[] programInfoArray = new RadioManager.ProgramInfo[2];



        int status = mRadioTuner.getProgramInformation(programInfoArray);



        assertWithMessage("Status for getting program info with input array of wrong size")

                .that(status).isEqualTo(RadioManager.STATUS_BAD_VALUE);

    }



    @Test

    public void getProgramInfo_beforeProgramInfoSetForTunerAdapter_fails() {

        RadioManager.ProgramInfo[] programInfoArray = new RadioManager.ProgramInfo[1];



        int status = mRadioTuner.getProgramInformation(programInfoArray);
@@ -731,6 +742,13 @@ public final class TunerAdapterTest { 
                .onBackgroundScanAvailabilityChange(/* isAvailable= */ false);

    }



    @Test

    public void onCurrentProgramInfoChanged_withNullInfo_notInvokeMockCallback() throws Exception {

        mTunerCallback.onCurrentProgramInfoChanged(null);



        verify(mCallbackMock, after(CALLBACK_TIMEOUT_MS).never()).onProgramInfoChanged(any());

    }



    @Test

    public void onProgramListChanged_forTunerCallbackAdapter() throws Exception {

        mTunerCallback.onProgramListChanged();