Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e32a6f40 authored by Eric Laurent's avatar Eric Laurent
Browse files

audioservice: add missing permission checks 

AudioManager getAudioVolumeGroups() and getAudioProductStrategies()
Are @SystemApi and should be protected by MODIFY_AUDIO_ROUTING permission
but no check was done on server side.

Bug: 154934920
Test: atest AudioManagerTest
Change-Id: I8f48eb83d8c2f55248f90a47240fd1547a1c2297
parent a2172bb2

services/core/java/com/android/server/audio/AudioService.java

+4 −0
Original line number Diff line number Diff line
@@ -1217,6 +1217,8 @@ public class AudioService extends IAudioService.Stub 
     */

    @NonNull

    public List<AudioProductStrategy> getAudioProductStrategies() {

        // verify permissions

        enforceModifyAudioRoutingPermission();

        return AudioProductStrategy.getAudioProductStrategies();

    }
@@ -1226,6 +1228,8 @@ public class AudioService extends IAudioService.Stub 
     */

    @NonNull

    public List<AudioVolumeGroup> getAudioVolumeGroups() {

        // verify permissions

        enforceModifyAudioRoutingPermission();

        return AudioVolumeGroup.getAudioVolumeGroups();

    }