Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e2f011c8 authored by Aaron Liu's avatar Aaron Liu
Browse files

[Bouncer] Change message to shared flow. 

Change to a shared flow so that the flow is not conflated. This will
allow the flow to emit values that are the same as the previous value.

Test: Add face unlock with someone not my face. Fail and disable face
unlock on bouncer.
Fixes: 258160993

Change-Id: Ibc68a23243a5ea88460199de1ea3ee876d658ea1
parent 7b0af203

packages/SystemUI/src/com/android/systemui/keyguard/data/repository/KeyguardBouncerRepository.kt

+10 −3
Original line number Diff line number Diff line
@@ -23,7 +23,10 @@ import com.android.systemui.keyguard.shared.model.BouncerShowMessageModel 
import com.android.systemui.keyguard.shared.model.KeyguardBouncerModel

import com.android.systemui.statusbar.phone.KeyguardBouncer

import javax.inject.Inject

import kotlinx.coroutines.channels.BufferOverflow

import kotlinx.coroutines.flow.MutableSharedFlow

import kotlinx.coroutines.flow.MutableStateFlow

import kotlinx.coroutines.flow.asSharedFlow

import kotlinx.coroutines.flow.asStateFlow



/** Encapsulates app state for the lock screen primary and alternate bouncer. */
@@ -68,8 +71,12 @@ constructor( 
    private val _keyguardAuthenticated = MutableStateFlow<Boolean?>(null)

    /** Determines if user is already unlocked */

    val keyguardAuthenticated = _keyguardAuthenticated.asStateFlow()

    private val _showMessage = MutableStateFlow<BouncerShowMessageModel?>(null)

    val showMessage = _showMessage.asStateFlow()

    private val _showMessage =

        MutableSharedFlow<BouncerShowMessageModel?>(

            replay = 1,

            onBufferOverflow = BufferOverflow.DROP_OLDEST

        )

    val showMessage = _showMessage.asSharedFlow()

    private val _resourceUpdateRequests = MutableStateFlow(false)

    val resourceUpdateRequests = _resourceUpdateRequests.asStateFlow()

    val bouncerPromptReason: Int
@@ -118,7 +125,7 @@ constructor( 
    }



    fun setShowMessage(bouncerShowMessageModel: BouncerShowMessageModel?) {

        _showMessage.value = bouncerShowMessageModel

        _showMessage.tryEmit(bouncerShowMessageModel)

    }



    fun setKeyguardAuthenticated(keyguardAuthenticated: Boolean?) {

packages/SystemUI/src/com/android/systemui/keyguard/domain/interactor/PrimaryBouncerInteractor.kt

+0 −1
Original line number Diff line number Diff line
@@ -117,7 +117,6 @@ constructor( 
    @JvmOverloads

    fun show(isScrimmed: Boolean) {

        // Reset some states as we show the bouncer.

        repository.setShowMessage(null)

        repository.setOnScreenTurnedOff(false)

        repository.setKeyguardAuthenticated(null)

        repository.setPrimaryHide(false)

packages/SystemUI/tests/src/com/android/systemui/keyguard/domain/interactor/PrimaryBouncerInteractorTest.kt

+0 −1
Original line number Diff line number Diff line
@@ -93,7 +93,6 @@ class PrimaryBouncerInteractorTest : SysuiTestCase() { 
    @Test

    fun testShow_isScrimmed() {

        mPrimaryBouncerInteractor.show(true)

        verify(repository).setShowMessage(null)

        verify(repository).setOnScreenTurnedOff(false)

        verify(repository).setKeyguardAuthenticated(null)

        verify(repository).setPrimaryHide(false)