Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e2cc3f8b authored by Jeff Sharkey's avatar Jeff Sharkey
Browse files

Additional per-file OWNERS for shared directories. 

Iteration based on areas of tree where detailed ownership was found
to be missing during routine code reviews.

Also add more detailed examples to OWNERS.md.

Bug: 174932174
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Change-Id: I46ccef33b34594181ae8dc62973d68020f827d6b
parent c9dc68f0

OWNERS

+1 −1
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ svetoslavganov@google.com 
yamasani@google.com



# Support bulk translation updates

per-file */res*/values*/*.xml = byi@google.com

per-file */res*/values*/*.xml = byi@google.com, delphij@google.com



per-file Android.bp = file:platform/build/soong:/OWNERS

per-file Android.mk = file:platform/build/soong:/OWNERS

OWNERS.md

+34 −0
Original line number Diff line number Diff line 
# Background



As general background, `OWNERS` files expedite code reviews by helping code

authors quickly find relevant reviewers, and they also ensure that stakeholders

are involved in code changes in their areas.
@@ -27,8 +29,40 @@ main `services/core/` project: 
  * `media/`

  * `wifi/`



# Design



Area maintainers are strongly encouraged to list people in a single

authoritative `OWNERS` file in **exactly one** location.  Then, other paths

should reference that single authoritative `OWNERS` file using an include

directive.  This approach ensures that updates are applied consistently across

the tree, reducing maintenance burden.



# Examples



The exact syntax of `OWNERS` files can be difficult to get correct, so here are

some common examples:



```

# Complete include of top-level owners from this repo

include /ZYGOTE_OWNERS

# Partial include of top-level owners from this repo

per-file ZygoteFile.java = file:/ZYGOTE_OWNERS

```

```

# Complete include of subdirectory owners from this repo

include /services/core/java/com/android/server/net/OWNERS

# Partial include of subdirectory owners from this repo

per-file NetworkFile.java = file:/services/core/java/com/android/server/net/OWNERS

```

```

# Complete include of top-level owners from another repo

include platform/libcore:/OWNERS

# Partial include of top-level owners from another repo

per-file LibcoreFile.java = file:platform/libcore:/OWNERS

```

```

# Complete include of subdirectory owners from another repo

include platform/frameworks/av:/camera/OWNERS

# Partial include of subdirectory owners from another repo

per-file CameraFile.java = file:platform/frameworks/av:/camera/OWNERS

```

core/java/android/app/OWNERS

+3 −0
Original line number Diff line number Diff line 
per-file *Alarm* = file:/apex/jobscheduler/OWNERS

per-file *AppOp* = file:/core/java/android/permission/OWNERS

per-file *Notification* = file:/packages/SystemUI/OWNERS

per-file *Zygote* = file:/ZYGOTE_OWNERS

core/java/android/os/OWNERS

+3 −0
Original line number Diff line number Diff line
@@ -24,4 +24,7 @@ per-file PowerComponents.java = file:/BATTERY_STATS_OWNERS 


per-file GraphicsEnvironment.java = chrisforbes@google.com, cnorthrop@google.com, lpy@google.com, timvp@google.com, zzyiwei@google.com



per-file *Network* = file:/services/core/java/com/android/server/net/OWNERS

per-file *Power* = file:/services/core/java/com/android/server/power/OWNERS

per-file *Telephony* = file:/telephony/OWNERS

per-file *Zygote* = file:/ZYGOTE_OWNERS

core/java/android/telephony/OWNERS

0 → 100644
+1 −0
Original line number Diff line number Diff line 
include /telephony/OWNERS