Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e2a4a6ff authored by Nicolas Prevot's avatar Nicolas Prevot Committed by Rubin Xu
Browse files

Don't always transfer device owner status to other users. 

A device owner cannot use device or profile owner policies on
other users unless it is profile owner there. Also limit device
initializer to system apps only.

Bug: 21800830
Change-Id: Ie1abbd891945b91b17ecdf7f73ba93aaa19819be
parent 7157c2ca

services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java

+15 −2
Original line number Diff line number Diff line
@@ -1277,11 +1277,13 @@ public class DevicePolicyManagerService extends IDevicePolicyManager.Stub { 
                && !hasUserSetupCompleted(userId);



        if (reqPolicy == DeviceAdminInfo.USES_POLICY_DEVICE_OWNER) {

            if (ownsDevice || (userId == UserHandle.USER_OWNER && ownsInitialization)) {

            if ((userId == UserHandle.USER_OWNER && (ownsDevice || ownsInitialization))

                    || (ownsDevice && ownsProfile)) {

                return true;

            }

        } else if (reqPolicy == DeviceAdminInfo.USES_POLICY_PROFILE_OWNER) {

            if (ownsDevice || ownsProfile || ownsInitialization) {

            if ((userId == UserHandle.USER_OWNER && ownsDevice) || ownsProfile

                    || ownsInitialization) {

                return true;

            }

        } else {
@@ -4236,6 +4238,17 @@ public class DevicePolicyManagerService extends IDevicePolicyManager.Stub { 
            throw new IllegalArgumentException("Invalid component name " + initializer

                    + " for device initializer");

        }

        boolean isInitializerSystemApp;

        try {

            isInitializerSystemApp = isSystemApp(AppGlobals.getPackageManager(),

                    initializer.getPackageName(), Binder.getCallingUserHandle().getIdentifier());

        } catch (RemoteException | IllegalArgumentException e) {

            isInitializerSystemApp = false;

            Slog.e(LOG_TAG, "Fail to check if device initialzer is system app.", e);

        }

        if (!isInitializerSystemApp) {

            throw new IllegalArgumentException("Only system app can be set as device initializer.");

        }

        synchronized (this) {

            enforceCanSetDeviceInitializer(who);