Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e264c9ed authored by Pavel Grafov's avatar Pavel Grafov
Browse files

Clean up dont_write_policy_definition 

The flag has been rolled out and has been in trunkfood since Nov 5th.

Bug: 335663055
Test: TH
Flag: EXEMPT flag cleanup, only removing dead code
Change-Id: I184fbff2ffe00a247af44b346ef53a995ff66d5c
parent 92f601e8

core/java/android/app/admin/flags/flags.aconfig

+0 −10
Original line number Original line Diff line number Diff line
@@ -342,16 +342,6 @@ flag { 
    }

    }

}

}





flag {

    name: "dont_write_policy_definition"

    namespace: "enterprise"

    description: "Don't write redundant policy-definition-entry tags"

    bug: "335663055"

    metadata {

        purpose: PURPOSE_BUGFIX

    }

}



flag {

flag {

    name: "active_admin_cleanup"

    name: "active_admin_cleanup"

    namespace: "enterprise"

    namespace: "enterprise"

services/devicepolicy/java/com/android/server/devicepolicy/PolicyDefinition.java

+0 −4
Original line number Original line Diff line number Diff line
@@ -656,10 +656,6 @@ final class PolicyDefinition<V> { 
        }

        }

    }

    }





    void saveToXml(TypedXmlSerializer serializer) throws IOException {

        mPolicyKey.saveToXml(serializer);

    }



    @Nullable

    @Nullable

    static <V> PolicyDefinition<V> readFromXml(TypedXmlPullParser parser)

    static <V> PolicyDefinition<V> readFromXml(TypedXmlPullParser parser)

            throws XmlPullParserException, IOException {

            throws XmlPullParserException, IOException {

services/devicepolicy/java/com/android/server/devicepolicy/PolicyState.java

+0 −8
Original line number Original line Diff line number Diff line
@@ -19,7 +19,6 @@ package com.android.server.devicepolicy; 
import android.annotation.NonNull;

import android.annotation.NonNull;

import android.annotation.Nullable;

import android.annotation.Nullable;

import android.app.admin.PolicyValue;

import android.app.admin.PolicyValue;

import android.app.admin.flags.Flags;

import android.util.IndentingPrintWriter;

import android.util.IndentingPrintWriter;





import com.android.internal.util.XmlUtils;

import com.android.internal.util.XmlUtils;
@@ -41,7 +40,6 @@ final class PolicyState<V> { 
    private static final String TAG = "PolicyState";

    private static final String TAG = "PolicyState";

    private static final String TAG_ADMIN_POLICY_ENTRY = "admin-policy-entry";

    private static final String TAG_ADMIN_POLICY_ENTRY = "admin-policy-entry";





    private static final String TAG_POLICY_DEFINITION_ENTRY = "policy-definition-entry";

    private static final String TAG_RESOLVED_VALUE_ENTRY = "resolved-value-entry";

    private static final String TAG_RESOLVED_VALUE_ENTRY = "resolved-value-entry";

    private static final String TAG_ENFORCING_ADMIN_ENTRY = "enforcing-admin-entry";

    private static final String TAG_ENFORCING_ADMIN_ENTRY = "enforcing-admin-entry";

    private static final String TAG_POLICY_VALUE_ENTRY = "policy-value-entry";

    private static final String TAG_POLICY_VALUE_ENTRY = "policy-value-entry";
@@ -225,12 +223,6 @@ final class PolicyState<V> { 
    }

    }





    void saveToXml(TypedXmlSerializer serializer) throws IOException {

    void saveToXml(TypedXmlSerializer serializer) throws IOException {

        if (!Flags.dontWritePolicyDefinition()) {

            serializer.startTag(/* namespace= */ null, TAG_POLICY_DEFINITION_ENTRY);

            mPolicyDefinition.saveToXml(serializer);

            serializer.endTag(/* namespace= */ null, TAG_POLICY_DEFINITION_ENTRY);

        }



        if (mCurrentResolvedPolicy != null) {

        if (mCurrentResolvedPolicy != null) {

            serializer.startTag(/* namespace= */ null, TAG_RESOLVED_VALUE_ENTRY);

            serializer.startTag(/* namespace= */ null, TAG_RESOLVED_VALUE_ENTRY);

            mPolicyDefinition.savePolicyValueToXml(

            mPolicyDefinition.savePolicyValueToXml(