Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e22e47f4 authored by evitayan's avatar evitayan
Browse files

Allow mainline IPsec(IKE) to statically include @PolicyDirection 

@PolicyDirection was hidden API defined in IpSecManager and
mainline module IPsec(IKE) needs to depend on it.

To remove this hidden API dependency, this commit:
- Moves definition of @PolicyDirection to a separate class
- Creates sharing filegroup framework-ike-shared-srcs for mainline
  IKE and include PolicyDirection.java

Bug: 146360859
Test: build, flash, boot
Test: atest FrameworksIkeTests
Change-Id: Ic6d7c06d4b92e16a9a65430365c9acc73932147b
parent 18077c15

Android.bp

+8 −0
Original line number Diff line number Diff line
@@ -586,6 +586,14 @@ java_library { 
    sdk_version: "current",

}



filegroup {

    name: "framework-ike-shared-srcs",

    visibility: ["//frameworks/opt/net/ike"],

    srcs: [

        "core/java/android/net/annotations/PolicyDirection.java",

    ],

}



filegroup {

    name: "framework-networkstack-shared-srcs",

    srcs: [

core/java/android/net/IpSecManager.java

+1 −8
Original line number Diff line number Diff line
@@ -17,7 +17,6 @@ package android.net; 


import static com.android.internal.util.Preconditions.checkNotNull;



import android.annotation.IntDef;

import android.annotation.NonNull;

import android.annotation.RequiresFeature;

import android.annotation.RequiresPermission;
@@ -26,6 +25,7 @@ import android.annotation.SystemService; 
import android.annotation.TestApi;

import android.content.Context;

import android.content.pm.PackageManager;

import android.net.annotations.PolicyDirection;

import android.os.Binder;

import android.os.ParcelFileDescriptor;

import android.os.RemoteException;
@@ -41,8 +41,6 @@ import dalvik.system.CloseGuard; 


import java.io.FileDescriptor;

import java.io.IOException;

import java.lang.annotation.Retention;

import java.lang.annotation.RetentionPolicy;

import java.net.DatagramSocket;

import java.net.InetAddress;

import java.net.Socket;
@@ -78,11 +76,6 @@ public final class IpSecManager { 
     */

    public static final int DIRECTION_OUT = 1;



    /** @hide */

    @IntDef(value = {DIRECTION_IN, DIRECTION_OUT})

    @Retention(RetentionPolicy.SOURCE)

    public @interface PolicyDirection {}



    /**

     * The Security Parameter Index (SPI) 0 indicates an unknown or invalid index.

     *

core/java/android/net/annotations/PolicyDirection.java

0 → 100644
+35 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2019 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */



package android.net.annotations;



import android.annotation.IntDef;

import android.net.IpSecManager;



import java.lang.annotation.Retention;

import java.lang.annotation.RetentionPolicy;



/**

 * IPsec traffic direction.

 *

 * <p>Mainline modules cannot reference hidden @IntDef. Moving this annotation to a separate class

 * to allow others to statically include it.

 *

 * @hide

 */

@IntDef(value = {IpSecManager.DIRECTION_IN, IpSecManager.DIRECTION_OUT})

@Retention(RetentionPolicy.SOURCE)

public @interface PolicyDirection {}