Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e1e7338b authored by George Lin's avatar George Lin
Browse files

Do not listen to clock change if should hide clock 

No need to listen to changes of clocks if clock is not shown in the
preview

Test: manually tested that there is no weird flash of smart space
Test: from clock updates when shouldHideClock
Bug: 282080440
Change-Id: I1508bb798b3984ac01d5c6b95cba58d2f4663fab
parent 66ca3625

packages/SystemUI/src/com/android/systemui/keyguard/ui/preview/KeyguardPreviewRenderer.kt

+16 −19
Original line number Diff line number Diff line
@@ -122,7 +122,9 @@ constructor( 


            setUpUdfps(rootView)



            if (!shouldHideClock) {

                setUpClock(rootView)

            }



            rootView.measure(

                View.MeasureSpec.makeMeasureSpec(
@@ -352,7 +354,7 @@ constructor( 
        clockController.clock = clock



        colorOverride?.let { clock.events.onSeedColorChanged(it) }

        if (!shouldHideClock) {



        clock.largeClock.events.onTargetRegionChanged(

            KeyguardClockSwitch.getLargeClockRegion(parentView)

        )
@@ -366,14 +368,9 @@ constructor( 
                parentView.addView(this)

                visibility = View.VISIBLE

            }

        } else {

            clockView?.visibility = View.GONE

        }



        // Hide smart space if the clock has weather display; otherwise show it

        val hasCustomWeatherDataDisplay =

            clock.largeClock.config.hasCustomWeatherDataDisplay == true

        hideSmartspace(hasCustomWeatherDataDisplay)

        hideSmartspace(clock.largeClock.config.hasCustomWeatherDataDisplay)

    }



    companion object {