Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e1aa26c7 authored by Tyler Gunn's avatar Tyler Gunn
Browse files

Make TelecomManager#endCall a public API. 

A broad category of apps such as wearable companion apps and call blocking
apps rely on the ability to reject a ringing call.
Previously this was achieved using a broken TelephonyManager API which
lacked permission checks.
To support these applications, removing the @hide attribute on the existing
TelecomManager#endCall API so that apps with the existing
ANSWER_PHONE_CALLS permission can reject ringing calls and end ongoing
calls.  Logically if an app has permission to answer a call, it should be
able to end it.

Test: Created test app to verify API permission checks.
Test: Added new CTS tests to cover this API.
Bug: 78290258
Change-Id: Ic6527969793ebe05eb9c5fa8205558ae788ea572
parent 68f36d6b

api/current.txt

+1 −0
Original line number Diff line number Diff line
@@ -41425,6 +41425,7 @@ package android.telecom { 
    method public void addNewIncomingCall(android.telecom.PhoneAccountHandle, android.os.Bundle);

    method public void cancelMissedCallsNotification();

    method public android.content.Intent createManageBlockedNumbersIntent();

    method public boolean endCall();

    method public android.net.Uri getAdnUriForPhoneAccount(android.telecom.PhoneAccountHandle);

    method public java.util.List<android.telecom.PhoneAccountHandle> getCallCapablePhoneAccounts();

    method public java.lang.String getDefaultDialerPackage();

telecomm/java/android/telecom/TelecomManager.java

+10 −5
Original line number Diff line number Diff line
@@ -1299,13 +1299,18 @@ public class TelecomManager { 
    }



    /**

     * Ends an ongoing call.

     * TODO: L-release - need to convert all invocations of ITelecomService#endCall to use this

     * method (clockwork & gearhead).

     * @hide

     * Ends the foreground call on the device.

     * <p>

     * If there is a ringing call, calling this method rejects the ringing call.  Otherwise the

     * foreground call is ended.

     * <p>

     * Requires permission {@link android.Manifest.permission#ANSWER_PHONE_CALLS}.

     *

     * @return {@code true} if there is a call which will be rejected or terminated, {@code false}

     * otherwise.

     */

    @RequiresPermission(Manifest.permission.ANSWER_PHONE_CALLS)

    @SystemApi

    @RequiresPermission(android.Manifest.permission.MODIFY_PHONE_STATE)

    public boolean endCall() {

        try {

            if (isServiceConnected()) {