Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e19d916a authored by Azhara Assanova's avatar Azhara Assanova
Browse files

Baseline global lint errors 

We're trying to update AndroidGlobalLintChecker to the latest version in
Change-Id If8b415f0a539a385e4fc6a161b2d533d452186d1 in AOSP, however, a
few lint errors fail presubmit, hence this change updates some baseline
files to make presubmit pass for now.

Bug: 366207898
Test: treehugger
Test: m services.appfunctions-lint
Test: m services.supervision-lint
Flag: EXEMPT lint baseline
Change-Id: I817389b0c7509711f9b27af44db79145f521bbb7
parent eff4dad4

services/appfunctions/Android.bp

+3 −0
Original line number Diff line number Diff line
@@ -22,4 +22,7 @@ java_library_static { 
        "java/**/*.logtags",

    ],

    libs: ["services.core"],

    lint: {

        baseline_filename: "lint-baseline.xml",

    },

}

services/appfunctions/lint-baseline.xml

0 → 100644
+26 −0
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="UTF-8"?>

<issues format="6" by="lint 8.4.0-alpha08" type="baseline" client="" dependencies="true" name="" variant="all" version="8.4.0-alpha08">



    <issue

        id="MissingPermissionAnnotation"

        message="executeAppFunction should be annotated with either @EnforcePermission, @RequiresNoPermission or @PermissionManuallyEnforced."

        errorLine1="    @Override"

        errorLine2="    ^">

        <location

            file="frameworks/base/services/appfunctions/java/com/android/server/appfunctions/AppFunctionManagerServiceImpl.java"

            line="101"

            column="5"/>

    </issue>



    <issue

        id="MissingPermissionAnnotation"

        message="onResult should be annotated with either @EnforcePermission, @RequiresNoPermission or @PermissionManuallyEnforced."

        errorLine1="                                                @Override"

        errorLine2="                                                ^">

        <location

            file="frameworks/base/services/appfunctions/java/com/android/server/appfunctions/AppFunctionManagerServiceImpl.java"

            line="243"

            column="49"/>

    </issue>



</issues>

services/supervision/Android.bp

+3 −0
Original line number Diff line number Diff line
@@ -19,4 +19,7 @@ java_library_static { 
    defaults: ["platform_service_defaults"],

    srcs: [":services.supervision-sources"],

    libs: ["services.core"],

    lint: {

        baseline_filename: "lint-baseline.xml",

    },

}

services/supervision/lint-baseline.xml

0 → 100644
+48 −0
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="UTF-8"?>

<issues format="6" by="lint 8.4.0-alpha08" type="baseline" client="" dependencies="true" name="" variant="all" version="8.4.0-alpha08">



    <issue

        id="MissingPermissionAnnotation"

        message="isSupervisionEnabled should be annotated with either @EnforcePermission, @RequiresNoPermission or @PermissionManuallyEnforced."

        errorLine1="    @Override"

        errorLine2="    ^">

        <location

            file="frameworks/base/services/supervision/java/com/android/server/supervision/SupervisionService.java"

            line="45"

            column="5"/>

    </issue>



    <issue

        id="MissingPermissionAnnotation"

        message="onShellCommand should be annotated with either @EnforcePermission, @RequiresNoPermission or @PermissionManuallyEnforced."

        errorLine1="    @Override"

        errorLine2="    ^">

        <location

            file="frameworks/base/services/supervision/java/com/android/server/supervision/SupervisionService.java"

            line="50"

            column="5"/>

    </issue>



    <issue

        id="MissingPermissionAnnotation"

        message="dump should be annotated with either @EnforcePermission, @RequiresNoPermission or @PermissionManuallyEnforced."

        errorLine1="    @Override"

        errorLine2="    ^">

        <location

            file="frameworks/base/services/supervision/java/com/android/server/supervision/SupervisionService.java"

            line="62"

            column="5"/>

    </issue>



    <issue

        id="SimpleRequiresNoPermission"

        message="Method isSupervisionEnabled doesn&apos;t perform any permission checks, meaning it should be annotated with @RequiresNoPermission."

        errorLine1="    @Override"

        errorLine2="    ^">

        <location

            file="frameworks/base/services/supervision/java/com/android/server/supervision/SupervisionService.java"

            line="45"

            column="5"/>

    </issue>



</issues>