Commit e17f5f5b authored Sep 27, 2013 by Maunik Shah Committed by Steve Kondik Nov 10, 2013

frameworks/base: Fix memory leak in BitmapRegionDecoder

When un-supported image is passed to bitmap decoder, mStream object
of SkMemoryStream class is leaking its resources. This is getting
called frequently when gallery app is trying to render thumbnails
in album view and due to this frequent sigkills were seen on
gallery3d app with adj 0 value

CRs-Fixed: 551617
Change-Id: I1d9401310566b529d81b406213f4e37be3104d95

parent 4dd3f322

core/jni/android/graphics/BitmapRegionDecoder.cpp

+5 −0

Original line number	Diff line number	Diff line
		@@ -158,6 +158,11 @@ static jobject nativeNewInstanceFromStream(JNIEnv* env, jobject clazz,
		// for now we don't allow shareable with java inputstreams
		SkMemoryStream *mStream = buildSkMemoryStream(stream);
		largeBitmap = doBuildTileIndex(env, mStream);
		// release the resources when decoding fails
		if (largeBitmap == NULL) {
		delete(mStream);
		mStream = NULL;
		}
		stream->unref();
		}
		return largeBitmap;