Require minimum 4 bit stencil for layers. (e1450131) · Commits · e / os / android_frameworks_base

libs/hwui/OpenGLRenderer.cpp

+1 −1

Original line number	Diff line number	Diff line
		@@ -1262,7 +1262,7 @@ void OpenGLRenderer::attachStencilBufferToLayer(Layer* layer) {
		endTiling();

		RenderBuffer* buffer = mCaches.renderBufferCache.get(
		Stencil::getSmallestStencilFormat(),
		Stencil::getLayerStencilFormat(),
		layer->getWidth(), layer->getHeight());
		layer->setStencilRenderBuffer(buffer);

+9 −4

Original line number	Diff line number	Diff line
		@@ -42,12 +42,17 @@ uint8_t Stencil::getStencilSize() {
		return STENCIL_BUFFER_SIZE;
		}

		GLenum Stencil::getSmallestStencilFormat() {
		/**
		* This method will return either GL_STENCIL_INDEX4_OES if supported,
		* GL_STENCIL_INDEX8 if not.
		*
		* Layers can't use a single bit stencil because multi-rect ClipArea needs a high enough
		* stencil resolution to represent the summation of multiple intersecting rect geometries.
		*/
		GLenum Stencil::getLayerStencilFormat() {
		#if !DEBUG_STENCIL
		const Extensions& extensions = Caches::getInstance().extensions();
		if (extensions.has1BitStencil()) {
		return GL_STENCIL_INDEX1_OES;
		} else if (extensions.has4BitStencil()) {
		if (extensions.has4BitStencil()) {
		return GL_STENCIL_INDEX4_OES;
		}
		#endif

+1 −4

Original line number	Diff line number	Diff line
		@@ -42,10 +42,7 @@ public:
		*/
		ANDROID_API static uint8_t getStencilSize();

		/**
		* Returns the smallest stencil format accepted by render buffers.
		*/
		static GLenum getSmallestStencilFormat();
		static GLenum getLayerStencilFormat();

		/**
		* Clears the stencil buffer.