Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e077f57c authored by Chenjie Yu's avatar Chenjie Yu
Browse files

remove unnecessary pulls in gaugemetric 

GaugeMetric need only pull on first bucket and partial bucket if it is
random_one_sample type

Test: unit test
Change-Id: I85cfbc2a14829245ce34ab801c553a3097e2e4b8
parent d462993e

cmds/statsd/src/metrics/GaugeMetricProducer.cpp

+1 −1
Original line number Diff line number Diff line
@@ -140,7 +140,7 @@ GaugeMetricProducer::GaugeMetricProducer(const ConfigKey& key, const GaugeMetric 


    // Adjust start for partial bucket

    mCurrentBucketStartTimeNs = startTimeNs;

    if (mIsPulled) {

    if (mIsPulled && mSamplingType == GaugeMetric::RANDOM_ONE_SAMPLE) {

        pullAndMatchEventsLocked(startTimeNs);

    }

cmds/statsd/src/metrics/GaugeMetricProducer.h

+1 −1
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ public: 
        }

        flushCurrentBucketLocked(eventTimeNs);

        mCurrentBucketStartTimeNs = eventTimeNs;

        if (mIsPulled) {

        if (mIsPulled && mSamplingType == GaugeMetric::RANDOM_ONE_SAMPLE) {

            pullAndMatchEventsLocked(eventTimeNs);

        }

    };