Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e05817ff authored by Steve Elliott's avatar Steve Elliott
Browse files

Fix dropped rotation events when unlocking orientation 

When unlocking orientation on the same frame as a rotation takes place
(example: orientation is locked to landscape, but phone is physically
oriented to portrait), onConfigurationChange is not invoked, and so
Global Actions is positioned as if it were in the locked orientation,
even though it has been rotated.

We work around this by post()ing the rotation unlock, so that it
happens on the next frame, at which point onConfigurationChange is
correctly invoked and the layout is re-oriented properly.

Fixes: 132581161
Test: manual
Change-Id: I1c11844e24bea115f9f44560fef8db863d19d7af
parent f4744c68

packages/SystemUI/src/com/android/systemui/globalactions/GlobalActionsDialog.java

+10 −4
Original line number Diff line number Diff line
@@ -1564,8 +1564,11 @@ public class GlobalActionsDialog implements DialogInterface.OnDismissListener, 
                    }



                    // Unlock rotation, so user can choose to rotate to portrait to see the panel.

                    // This call is posted so that the rotation does not change until post-layout,

                    // otherwise onConfigurationChanged() may not get invoked.

                    mGlobalActionsLayout.post(() ->

                            RotationPolicy.setRotationLockAtAngle(

                            mContext, false, RotationUtils.ROTATION_NONE);

                                    mContext, false, RotationUtils.ROTATION_NONE));

                }

            } else {

                if (!rotationLocked) {
@@ -1575,8 +1578,11 @@ public class GlobalActionsDialog implements DialogInterface.OnDismissListener, 
                    }



                    // Lock to portrait, so the user doesn't accidentally hide the panel.

                    // This call is posted so that the rotation does not change until post-layout,

                    // otherwise onConfigurationChanged() may not get invoked.

                    mGlobalActionsLayout.post(() ->

                            RotationPolicy.setRotationLockAtAngle(

                            mContext, true, RotationUtils.ROTATION_NONE);

                                    mContext, true, RotationUtils.ROTATION_NONE));

                }



                // Disable rotation suggestions, if enabled