Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e017e96e authored by henry.uh_chen's avatar henry.uh_chen Committed by Steve Kondik
Browse files

[View] Clear Hardware-Layers before system destroys HardwareRenderer​. 

Symptom: Sometimes HardwareLayer display is corrupted.

Root Cause: In some cases, ViewRootImpl destroys HardwareRenderer​ without
clearing HardwareLayers in the view hirarchy. If the system trims memory fully
and kill the glContext at the same time, HardwareLayer may corrupt.

Solution: Clear Hardware-Layers before system destroys HardwareRenderer​.

Reproduce steps: Modify the cache's trim memory mechanism to make it easier to
trim fully, HardwareLayers implemented in app will easily be corrupted.
Modification of the cache is not required but make it easier to reproduce.

Change-Id: If57c802cdacf8dc37cbbcc199e74f9482834f981
parent 578333c0

core/java/android/view/ViewRootImpl.java

100644 → 100755
+3 −0
Original line number Diff line number Diff line
@@ -1565,6 +1565,9 @@ public final class ViewRootImpl implements ViewParent, 
                    // Our surface is gone

                    if (mAttachInfo.mHardwareRenderer != null &&

                            mAttachInfo.mHardwareRenderer.isEnabled()) {

                        // Destroy hardware layers before hardware renderer is destroyed

                        mAttachInfo.mHardwareRenderer.destroyHardwareResources(mView);



                        mAttachInfo.mHardwareRenderer.destroy(true);

                    }

                } else if (surfaceGenerationId != mSurface.getGenerationId() &&