Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dfb437e1 authored by Brad Fitzpatrick's avatar Brad Fitzpatrick
Browse files

Fix Parcel leak in ContentProvider.call()

This manifested itself as memory allocation and Binder failures during
my load testing / benchmarking.

BUG=2498615

Change-Id: I260fd916f97777fc98bee98d10474f12deb21dee
parent 68da044d
Loading
Loading
Loading
Loading
+6 −1
Original line number Diff line number Diff line
@@ -515,7 +515,12 @@ final class ContentProviderProxy implements IContentProvider
        mRemote.transact(IContentProvider.CALL_TRANSACTION, data, reply, 0);

        DatabaseUtils.readExceptionFromParcel(reply);
        return reply.readBundle();
        Bundle bundle = reply.readBundle();

        data.recycle();
        reply.recycle();

        return bundle;
    }

    private IBinder mRemote;