Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dfaae655 authored by Marzia Favaro's avatar Marzia Favaro
Browse files

Revert "Improve PIA dim causing UI flash" 

This reverts commit 2973fdd1.

Reason for revert: ag/24800533 provides a fix to the bug and does not require this workaround anymore

Change-Id: Ib45af509f0e3086c2769ce81d4783d2b448ba5ed
parent 567f2472

packages/PackageInstaller/AndroidManifest.xml

+2 −6
Original line number Diff line number Diff line
@@ -75,10 +75,7 @@ 
            </intent-filter>

        </activity>



        <!-- NOTE: the workaround to fix the screen flash problem. Remember to check the problem

            is resolved for new implementation -->

        <activity android:name=".InstallStaging"

                  android:theme="@style/Theme.AlertDialogActivity.NoDim"

                android:exported="false" />



        <activity android:name=".DeleteStagedFileOnResult"
@@ -86,7 +83,6 @@ 
            android:exported="false" />



        <activity android:name=".PackageInstallerActivity"

                  android:theme="@style/Theme.AlertDialogActivity.NoAnimation"

                android:exported="false" />



        <activity android:name=".InstallInstalling"

packages/PackageInstaller/res/values/themes.xml

+0 −5
Original line number Diff line number Diff line
@@ -32,9 +32,4 @@ 
        <item name="android:windowNoTitle">true</item>

    </style>



    <style name="Theme.AlertDialogActivity.NoDim"

        parent="@style/Theme.AlertDialogActivity.NoActionBar">

        <item name="android:backgroundDimAmount">0</item>

    </style>



</resources>

packages/PackageInstaller/src/com/android/packageinstaller/PackageInstallerActivity.java

+1 −1
Original line number Diff line number Diff line
@@ -308,7 +308,6 @@ public class PackageInstallerActivity extends Activity { 
    }



    private void initiateInstall() {

        bindUi();

        String pkgName = mPkgInfo.packageName;

        // Check if there is already a package on the device with this name

        // but it has been renamed to something else.
@@ -448,6 +447,7 @@ public class PackageInstallerActivity extends Activity { 
        if (mAppSnippet != null) {

            // load placeholder layout with OK button disabled until we override this layout in

            // startInstallConfirm

            bindUi();

            checkIfAllowedAndInitiateInstall();

        }