Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit df9a44e1 authored by Zim's avatar Zim
Browse files

Make low storage notification PendingIntent immutable 

Malicious apps, especially NotificationListeners can hijack such
intents and grant themselves access to sensitive URIs by relying on
the OS URI granting mechanism. This change mitigates the security
issue and also adheres to the new enforcement requiring Android S+
targeting apps to explicitly specifiy a mutability flag.

Test: Manual
Bug: 153466381
Change-Id: If478386d68cf25c8f93c2685824700679e6b9ea9
parent 302b4758

services/core/java/com/android/server/storage/DeviceStorageMonitorService.java

+2 −2
Original line number Diff line number Diff line
@@ -472,8 +472,8 @@ public class DeviceStorageMonitorService extends SystemService { 
            final CharSequence details = context.getText(

                    com.android.internal.R.string.low_internal_storage_view_text);



            PendingIntent intent = PendingIntent.getActivityAsUser(context, 0, lowMemIntent, 0,

                    null, UserHandle.CURRENT);

            PendingIntent intent = PendingIntent.getActivityAsUser(context, 0, lowMemIntent,

                    PendingIntent.FLAG_IMMUTABLE, null, UserHandle.CURRENT);

            Notification notification =

                    new Notification.Builder(context, SystemNotificationChannels.ALERTS)

                            .setSmallIcon(com.android.internal.R.drawable.stat_notify_disk_full)