Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dd469d17 authored by Vladislav Kaznacheev's avatar Vladislav Kaznacheev
Browse files

Do not update currently open tooltip. 

Currently if View.setTooltipText is called while
the tooltip is being shown for that view, it will
update the displayed text. The tooltip then will
resize to wrap around the new text, but not change
its position. This looks confusing if the new text
is significantly shorter or longer.

Removing this functionality until proper
re-positioning is implemented.

Bug: 38491655
Test: android.view.cts.TooltipTest passes
Change-Id: I79689288185888854b992b89e19fe381d3ac50e4
parent d97c62a1

core/java/android/view/View.java

+0 −3
Original line number Diff line number Diff line
@@ -26273,9 +26273,6 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 
                mTooltipInfo.mHideTooltipRunnable = this::hideTooltip;

            }

            mTooltipInfo.mTooltipText = tooltipText;

            if (mTooltipInfo.mTooltipPopup != null && mTooltipInfo.mTooltipPopup.isShowing()) {

                mTooltipInfo.mTooltipPopup.updateContent(mTooltipInfo.mTooltipText);

            }

        }

    }

























core/java/com/android/internal/view/TooltipPopup.java



+0
−4




























Original line number
Diff line number
Diff line








@@ -91,10 +91,6 @@ public class TooltipPopup {













        return mContentView.getParent() != null;















    }





























    public void updateContent(CharSequence tooltipText) {













        mMessageView.setText(tooltipText);













    }





























    private void computePosition(View anchorView, int anchorX, int anchorY, boolean fromTouch,















            WindowManager.LayoutParams outParams) {















        outParams.token = anchorView.getWindowToken();