Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc23ef66 authored by Fabian Kozynski's avatar Fabian Kozynski
Browse files

Remove allocation from HeaderTileLayout#onLayout 

Moved allocation of Rect to construction, and only bounds are modified
on layout.

Also fixed typo

Test: visual, expanding animation on large display
Fixes: 131093881
Change-Id: I92e14deee73820c5c21d7328d6a84b3115bb3c1f
parent 18184f9c

packages/SystemUI/src/com/android/systemui/qs/QuickQSPanel.java

+5 −4
Original line number Diff line number Diff line
@@ -181,6 +181,7 @@ public class QuickQSPanel extends QSPanel { 
    private static class HeaderTileLayout extends TileLayout {



        private boolean mListening;

        private Rect mClippingBounds = new Rect();



        public HeaderTileLayout(Context context) {

            super(context);
@@ -219,8 +220,8 @@ public class QuickQSPanel extends QSPanel { 
        @Override

        protected void onLayout(boolean changed, int l, int t, int r, int b) {

            // We only care about clipping on the right side

            Rect bounds = new Rect(0, 0, r - l, 10000);

            setClipBounds(bounds);

            mClippingBounds.set(0, 0, r - l, 10000);

            setClipBounds(mClippingBounds);



            calculateColumns();
@@ -252,9 +253,9 @@ public class QuickQSPanel extends QSPanel { 
            }



            final int availableWidth = getMeasuredWidth() - getPaddingStart() - getPaddingEnd();

            final int leftoverWithespace = availableWidth - maxTiles * mCellWidth;

            final int leftoverWhitespace = availableWidth - maxTiles * mCellWidth;

            final int smallestHorizontalMarginNeeded;

            smallestHorizontalMarginNeeded = leftoverWithespace / Math.max(1, maxTiles - 1);

            smallestHorizontalMarginNeeded = leftoverWhitespace / Math.max(1, maxTiles - 1);



            if (smallestHorizontalMarginNeeded > 0){

                mCellMarginHorizontal = smallestHorizontalMarginNeeded;